-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(indexer): remove indexer all command #7247
chore(indexer): remove indexer all command #7247
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Semgrep found 1
A secret is hard-coded in the application. Secrets stored in source code, such as credentials, identifiers, and other types of sensitive data, can be leaked and used by internal or external malicious actors. Use environment variables to securely provide credentials and other secrets or retrieve them from a secure vault or Hardware Security Module (HSM). View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>indexer/database/db.go</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0("<b>[Line: 49]</b> #quot; password=%s#quot;")
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2("<b>[Line: 49]</b> dsn")
end
%% Sink
subgraph Sink
direction LR
v1("<b>[Line: 51]</b> gorm.Open(postgres.Open(dsn), &gorm.Config{<br> // The indexer will explicitly manage the transactions<br> SkipDefaultTransaction: true,<br> Logger: logger.Default.LogMode(logger.Silent),<br> })")
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
%% Clickable
click v0 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L49" "View in source" _blank
click v1 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L51" "View in source" _blank
click v2 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L49" "View in source" _blank
Semgrep found 1
The application uses an empty credential. This can lead to unauthorized access by either an internal or external malicious actor. Use environment variables to securely provide credentials and other secrets or retrieve them from a secure vault or Hardware Security Module (HSM). View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>indexer/database/db.go</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0("<b>[Line: 49]</b> #quot; password=%s#quot;")
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2("<b>[Line: 49]</b> dsn")
end
%% Sink
subgraph Sink
direction LR
v1("<b>[Line: 51]</b> gorm.Open(postgres.Open(dsn), &gorm.Config{<br> // The indexer will explicitly manage the transactions<br> SkipDefaultTransaction: true,<br> Logger: logger.Default.LogMode(logger.Silent),<br> })")
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
%% Clickable
click v0 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L49" "View in source" _blank
click v1 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L51" "View in source" _blank
click v2 href "https://github.com/ethereum-optimism/optimism/blob/59bb1d5de89646a9811dee014f95b02104eb1369/indexer/database/db.go#L49" "View in source" _blank
|
0a15ed1
to
91da739
Compare
59bb1d5
to
6d24e42
Compare
91da739
to
7318de6
Compare
6d24e42
to
149efb1
Compare
7318de6
to
d50c58f
Compare
Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review. |
d50c58f
to
bbc8a8d
Compare
149efb1
to
d7763d0
Compare
d7763d0
to
313fbaf
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
In k8s repo we are adding api as a new service and the new indexer replaces the old indexer/api