Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ chore: Make port configurable #7089

Merged
merged 3 commits into from
Sep 6, 2023
Merged

♻️ chore: Make port configurable #7089

merged 3 commits into from
Sep 6, 2023

Conversation

roninjin10
Copy link
Contributor

  • Make the postgres port configurable
  • Needed to deploy to render

@roninjin10 roninjin10 requested a review from a team as a code owner September 1, 2023 15:49
This was referenced Sep 1, 2023
Merged
Merged
@roninjin10
Copy link
Contributor Author

roninjin10 commented Sep 1, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Sep 1, 2023
Merged
Merged
@mergify mergify bot added the A-indexer Area: indexer label Sep 1, 2023
@roninjin10 roninjin10 mentioned this pull request Sep 1, 2023
Closed
hamdiallam
hamdiallam approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have defaults in the toml file while allowing them to be overridable via env variables? I wonder if the toml deser library allows for this

♻️ chore: Make port configurable
1857d61 
🐛 fix: Fix port env var
@roninjin10 roninjin10 changed the base branch from willc/copy-foundry.toml to develop September 6, 2023 07:01
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Sep 6, 2023
@OptimismBot OptimismBot merged commit b96f015 into develop Sep 6, 2023
6 of 7 checks passed
@OptimismBot OptimismBot deleted the willc/port branch September 6, 2023 07:24
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot added S-on-merge-train Status: This PR is in the merge queue and removed S-on-merge-train Status: This PR is in the merge queue labels Sep 6, 2023
This was referenced Sep 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamdiallam hamdiallam hamdiallam approved these changes

Assignees
No one assigned
Labels
A-indexer Area: indexer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roninjin10 @hamdiallam @OptimismBot