Disable HTML inputs for dict/list fields #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Jan 2, 2018
There was a problem hiding this comment.
Given current limitations, I agree that disabling these fields is the best approach.
The solution here is for users to provide their own templates adding whatever widgets are needed for their use-case. That's out of scope for core as of now. (Would make some good blog posts though.)
Closed
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListField&DictFielddo not seem to have proper HTML form support. Until they do, it would make sense to render a disabled form input, similar to how nested list serializers are currently handled.Is there any reason not to disable these inputs?
Additionally, I would add tests for this, but I don't see any relevant tests for serializer form rendering.