-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add requestgroups pages #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on portal api backend as they were being sent with every ajax request
…omponent, which saves from having to download the same requestgroup twice when there is only one request, and gets rids of lots of duplication
…rect to that route if it does
…till using the same component
jnation3406
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I didn't take the closest look at the files that looked like they were just copied over, but the end result looks good.
…int configurations, and then fixed issues
…ing something that seems hacky
Feature/cleanup code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled over components for the compose, request detail, and requestgroup detail pages.
I added a navigation guard in the router file that redirects a user to the login page if a route has been marked as requiring authentication but the user is not logged in. After logging in, the user will be redirected to the page they originally tried to load. So far for the pages that have been pulled over, this is needed for the compose page.
Added archive token authentication for loading thumbnails/ archive data.
This branch is deployed on http://observation-portal-separate-frontend.lco.gtn/