[WIP] Glimmer tags integration #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Glimmer 2 integration with Ember would recompute values in curlies on each top-down revalidation. This commit uses new features of the Glimmer engine to allow it to more cheaply revalidate a reference, and often skip the computation if the reference is sure the value cannot have changed.
krisselden
force-pushed
the
glimmer-tags
branch
2 times, most recently
from
ca37368 to
f909b4c
Compare
This was referenced Apr 8, 2016
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-pass implementation of integrating Glimmer's validators system
/cc @krisselden