Cleanup Meta Descs #12852
Cleanup Meta Descs #12852
Conversation
stefanpenner
commented
Jan 21, 2016
stefanpenner
commented
- make it work, run a normal app
- rebase
- fix last 9 failing tests
- cleanup LOLcode
- more stringent perf analysis + fixes
- decide how to handle setters
stefanpenner
force-pushed
the
restore-meta-descs
branch
from
28d8275 to
304f695
Compare
| export function defineProperty(obj, keyName, desc, data, meta) { | ||
| var possibleDesc, existingDesc, watching, value; | ||
| export function defineProperty(obj, keyName, desc, data/*, meta*/) { | ||
| let meta = arguments[4] || metaFor(obj); |
There was a problem hiding this comment.
a meta may not exists here yet, we should be careful to not create on if it does not need to exist.
|
@stefanpenner Is it possible to separate this into two PRs? a) undoing #10323 and b) getter and setter support? It looks like you've done the work for a) so we can land it asap? I'm happy to clean up the commit with your approval. |
|
Ya it's possible, as I was going through this code I realized many things required work-arounds and without a more full exploration, which work-around is more appropriate is tricky. Some performance considerations became obvious as well. So my goal here is to complete the whole exercise, get a full picture of the performance work, to allow my to see where the pieces fall then work backwards. Downside is ^ will take some time, and I have been pushed in another direction for the moment. I can try later this week to bring this to a close, or at-least split it up. |
|
In chat, @stefanpenner suggests that we implementing |
krisselden
force-pushed
the
restore-meta-descs
branch
12 times, most recently
from
ae8ad74 to
51cd45b
Compare
|
☔ The latest upstream changes (presumably #13278) made this pull request unmergeable. Please resolve the merge conflicts. |
krisselden
force-pushed
the
restore-meta-descs
branch
from
51cd45b to
5128ae7
Compare
|
☔ The latest upstream changes (presumably #13335) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@stefanpenner - thoughts on progressing this? |
|
@rwjblue planning to resume later this summer, unless someone else jumps in. |
