<mx-reply/> blocks which trigger highlights should be highlighted #6747
Labels
A-Replies
reply
P2
S-Minor
Impairs non-critical functionality or suitable workarounds exist
S-Tolerable
Low/no impact on users
T-Defect
Comments
|
because |
|
The problem is probably more that the highlight (Matthew) should be highlit rather than mx-reply blocks being excluded, in retrospect. The quickest solution is probably to just make the whole thing red. |
ara4n
changed the title
lampholder
added
T-Defect
P2
S-Minor
refi64
added a commit
to refi64/riot-web-lc
that referenced
this issue
Sep 28, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481. * Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064. * Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858. * Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088. * Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)). * Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694. * Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891. * Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007. * Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005. * Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods). * Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908. * Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798. * Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)). * Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677. * Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528. * Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018. * hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597. * Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935. * Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892. * Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)). * Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085. * Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)). * Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299. * Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)). * Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown). * Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown). * Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown). * Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025. * Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023. * Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034. * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid). * Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003. * Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist). * Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)). * Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown). * Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961. * Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951. * Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
coolmic
added a commit
to livegen/riot-web
that referenced
this issue
Oct 1, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481. * Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064. * Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858. * Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088. * Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)). * Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694. * Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891. * Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007. * Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005. * Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods). * Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908. * Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798. * Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)). * Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677. * Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528. * Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018. * hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597. * Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935. * Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892. * Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)). * Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085. * Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)). * Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299. * Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)). * Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown). * Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown). * Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown). * Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025. * Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023. * Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034. * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid). * Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003. * Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist). * Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)). * Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown). * Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961. * Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951. * Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
BBaoVanC
added a commit
to boba-best/element.boba.best
that referenced
this issue
Oct 2, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481. * Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064. * Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858. * Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088. * Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)). * Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694. * Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891. * Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007. * Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005. * Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods). * Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908. * Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798. * Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)). * Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677. * Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528. * Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018. * hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597. * Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935. * Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892. * Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)). * Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085. * Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)). * Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299. * Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)). * Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown). * Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown). * Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown). * Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025. * Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023. * Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034. * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid). * Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003. * Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist). * Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)). * Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown). * Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961. * Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951. * Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
|
the mx-reply fallback is going away as per the spec change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: