Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room upgrade flow during "Space members" doesn't link the new room to the previous parent spaces if you are not an admin of the space #18858

Closed
novocaine opened this issue Sep 1, 2021 · 11 comments · Fixed by matrix-org/matrix-react-sdk#6805
Assignees
Labels
A-Room-Settings A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@novocaine
Copy link
Contributor

novocaine commented Sep 1, 2021

Steps to reproduce

Room Settings -> Security & Privacy

Set the room access to "Space members" for a room that requires upgrading (will show an Upgrade required).

Don't be an admin of at least one of the parent spaces.

Go through with the upgrade as usual.

What happened?

The new room is created, but it silently won't be added to an old room's parent space if you're not an admin of it.

It's also not possible to link the room manually - the previous parent space doesn't show up in search.

Screenshot 2021-09-01 at 09 57 45

What did you expect?

Either

  • To be warned about the behaviour before the operation so I could get someone who is an admin of the space to perform the upgrade instead
  • Or less desirably, to be warned during the operation that re-linking had failed

Also interested in whether there's some way to avoid the problem entirely.

Operating system

OS X

Browser information

Chrome

URL for webapp

develop.element.io

Homeserver

matrix.org

Have you submitted a rageshake?

No

@novocaine novocaine added T-Defect A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 1, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 2, 2021

Given that users on other servers may have had the room in personal "Just Me" Spaces there really isn't much that can be done here, as no one server or user can update (or even know about) all spaces containing that room. This may require spec changes to work around to make the Hierarchy API resolve tombstones to the latest version of a room or similar.

@novocaine
Copy link
Contributor Author

There might not be a good general solution for the federated case, but at the very least, for the non-federated case, we should be able to do better in terms of detecting the problem and warning the user about it.

@t3chguy
Copy link
Member

t3chguy commented Sep 2, 2021

Sure, for the Spaces the user is in we can warn. But even for non-federated case where someone else has that room in a Just Me Space we can't really inform the admin upgrading as that'd be a privacy leak (plus it'd need a new API anyhow)

@novocaine
Copy link
Contributor Author

novocaine commented Sep 2, 2021

From out-of-band discussion, technically possible is:

  • Tell the user if we weren't able to successfully link the any of the known parents during the operation (better than silent fail?)
  • Warn the user before they start if we weren't able to find any parents with local perms suggesting the re-linking would succeed

@t3chguy

This comment has been minimized.

@niquewoodhouse
Copy link

I think I understand the issue. My preferred flow would be:

  • User trieds to upgrade room
  • Spinner spins
  • If doesn't link new room to previous rooms parent space, you're informed in a dialog which tells you which Spaces, the consequences, and asks if you want to proceed anyway.
  • If the above doesn't happen, directed to new room settings (already done)

Dialog:

image

I feel like because the upgrade will, in this instance[1], damage the room and the Spaces it's in, and the person upgrading is trying to improve the room, explicitly warning them is best.

[1] If I understand the issue correctly

@t3chguy
Copy link
Member

t3chguy commented Sep 10, 2021

you're informed in a dialog which tells you which Spaces, the consequences, and asks if you want to proceed anyway.

This won't remove the room from those spaces, it'll just not be able to update the link so the older room version will still be linked from those spaces, users joining via that link will join the older version and have a prompt to join the newer version from there.

We also have no way of knowing all spaces which contain this room, only the spaces which you are in (and don't have permission to update the link in)

@novocaine
Copy link
Contributor Author

yeah, we need to just be careful about the copy says, as what we can actually know for certain is very limited:

  • we will know if we weren't able to successfully link any of the known parents during the operation (suggesting something wasn't right)
  • before they start, we can tell if we weren't able to find any parents that we have admin on

@niquewoodhouse
Copy link

niquewoodhouse commented Sep 14, 2021

we will know if we weren't able to successfully link any of the known parents during the operation (suggesting something wasn't right)
before they start, we can tell if we weren't able to find any parents that we have admin on

These feel like two different messages.

  1. Suggesting something wasn't right - we couldn't link to any parents

Screenshot 2021-09-14 at 09 56 17

  1. We couldn't find any parents 'that we have admin on'

@t3chguy
Copy link
Member

t3chguy commented Sep 14, 2021

Suggesting something wasn't right - we couldn't link to any parents

We'd know ahead of time if we

  1. know of any parents containing this room
  2. are admin in any of those

but we will never know about all parents and thus also never be admin in all parents.
The Try again CTA on this modal makes no sense as nothing would be any different, you still wouldn't be.

We couldn't find any parents 'that we have admin on'

This modal seems to do the trick, maybe we could list the spaces for clarity

@niquewoodhouse
Copy link

This modal seems to do the trick, maybe we could list the spaces for clarity

Adding a list sounds helpful but we could do it later.

Copy from dialog:

This room is in some spaces you’re not an admin of. In those spaces, the old room will still be shown, but people will be prompted to join the new one.

@t3chguy t3chguy assigned t3chguy and unassigned niquewoodhouse Sep 14, 2021
refi64 added a commit to refi64/riot-web-lc that referenced this issue Sep 28, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
coolmic added a commit to livegen/riot-web that referenced this issue Oct 1, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Oct 2, 2021
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#19037](element-hq#19037)). Fixes element-hq#18481 and undefined/element-web#18481.
* Say Joining space instead of Joining room where we know its a space ([\element-hq#6818](matrix-org/matrix-react-sdk#6818)). Fixes element-hq#19064 and element-hq#19064.
* Add warning that some spaces may not be relinked to the newly upgraded room ([\element-hq#6805](matrix-org/matrix-react-sdk#6805)). Fixes element-hq#18858 and element-hq#18858.
* Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\element-hq#6594](matrix-org/matrix-react-sdk#6594)). Fixes element-hq#18088, element-hq#18524 element-hq#18088 and element-hq#18088.
* Show "Message" in the user info panel instead of "Start chat" ([\element-hq#6319](matrix-org/matrix-react-sdk#6319)). Fixes element-hq#17877 and element-hq#17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\element-hq#6804](matrix-org/matrix-react-sdk#6804)).
* Replace plain text emoji at the end of a line ([\element-hq#6784](matrix-org/matrix-react-sdk#6784)). Fixes element-hq#18833 and element-hq#18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Simplify Space Panel layout and fix some edge cases ([\element-hq#6800](matrix-org/matrix-react-sdk#6800)). Fixes element-hq#18694 and element-hq#18694.
* Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes element-hq#18891 and element-hq#18891.
* Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\element-hq#6790](matrix-org/matrix-react-sdk#6790)). Fixes element-hq#19007 and element-hq#19007.
* Fix automatic field population in space create menu not validating ([\element-hq#6792](matrix-org/matrix-react-sdk#6792)). Fixes element-hq#19005 and element-hq#19005.
* Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes element-hq#12876 and element-hq#12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods).
* Adapt and re-use the RolesRoomSettingsTab for Spaces ([\element-hq#6779](matrix-org/matrix-react-sdk#6779)). Fixes element-hq#18908 element-hq#18909 and element-hq#18908.
* Deduplicate join rule management between rooms and spaces ([\element-hq#6724](matrix-org/matrix-react-sdk#6724)). Fixes element-hq#18798 and element-hq#18798.
* Add config option to turn on in-room event sending timing metrics ([\element-hq#6766](matrix-org/matrix-react-sdk#6766)).
* Improve the upgrade for restricted user experience ([\element-hq#6764](matrix-org/matrix-react-sdk#6764)). Fixes element-hq#18677 and element-hq#18677.
* Improve tooltips on space quick actions and explore button ([\element-hq#6760](matrix-org/matrix-react-sdk#6760)). Fixes element-hq#18528 and element-hq#18528.
* Make space members and user info behave more expectedly ([\element-hq#6765](matrix-org/matrix-react-sdk#6765)). Fixes element-hq#17018 and element-hq#17018.
* hide no-op m.room.encryption events and better word param changes ([\element-hq#6747](matrix-org/matrix-react-sdk#6747)). Fixes element-hq#18597 and element-hq#18597.
* Respect m.space.parent relations if they hold valid permissions ([\element-hq#6746](matrix-org/matrix-react-sdk#6746)). Fixes element-hq#10935 and element-hq#10935.
* Space panel accessibility improvements ([\element-hq#6744](matrix-org/matrix-react-sdk#6744)). Fixes element-hq#18892 and element-hq#18892.
* Fix spacing for message composer buttons ([\element-hq#6854](matrix-org/matrix-react-sdk#6854)).
* Fix accessing field on oobData which may be undefined ([\element-hq#6830](matrix-org/matrix-react-sdk#6830)). Fixes element-hq#19085 and element-hq#19085.
* Fix reactions aria-label not being a string and thus being read as [Object object] ([\element-hq#6828](matrix-org/matrix-react-sdk#6828)).
* Fix missing null guard in space hierarchy pagination ([\element-hq#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299.
* Fix checks to show prompt to start new chats ([\element-hq#6812](matrix-org/matrix-react-sdk#6812)).
* Fix room list scroll jumps ([\element-hq#6777](matrix-org/matrix-react-sdk#6777)). Fixes element-hq#17460 element-hq#18440 and element-hq#17460. Contributed by [robintown](https://github.com/robintown).
* Fix various message bubble alignment issues ([\element-hq#6785](matrix-org/matrix-react-sdk#6785)). Fixes element-hq#18293, element-hq#18294 element-hq#18305 and element-hq#18293. Contributed by [robintown](https://github.com/robintown).
* Make message bubble font size consistent ([\element-hq#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown).
* Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes element-hq#19025 and element-hq#19025.
* Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes element-hq#19023 and element-hq#19023.
* Stop spinner on space preview if the join fails ([\element-hq#6803](matrix-org/matrix-react-sdk#6803)). Fixes element-hq#19034 and element-hq#19034.
* Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes element-hq#19012 and element-hq#19012. Contributed by [Palid](https://github.com/Palid).
* Fix autocomplete not having y-scroll ([\element-hq#6794](matrix-org/matrix-react-sdk#6794)). Fixes element-hq#18997 and element-hq#18997. Contributed by [Palid](https://github.com/Palid).
* Fix broken edge case with public space creation with no alias ([\element-hq#6791](matrix-org/matrix-react-sdk#6791)). Fixes element-hq#19003 and element-hq#19003.
* Redirect from /#/welcome to /#/home if already logged in ([\element-hq#6786](matrix-org/matrix-react-sdk#6786)). Fixes element-hq#18990 and element-hq#18990. Contributed by [aaronraimist](https://github.com/aaronraimist).
* Fix build issues from two conflicting PRs landing without merge conflict ([\element-hq#6780](matrix-org/matrix-react-sdk#6780)).
* Render guest settings only in public rooms/spaces ([\element-hq#6693](matrix-org/matrix-react-sdk#6693)). Fixes element-hq#18776 and element-hq#18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix message bubble corners being wrong in the presence of hidden events ([\element-hq#6776](matrix-org/matrix-react-sdk#6776)). Fixes element-hq#18124 and element-hq#18124. Contributed by [robintown](https://github.com/robintown).
* Debounce read marker update on scroll ([\element-hq#6771](matrix-org/matrix-react-sdk#6771)). Fixes element-hq#18961 and element-hq#18961.
* Use cursor:pointer on space panel buttons ([\element-hq#6770](matrix-org/matrix-react-sdk#6770)). Fixes element-hq#18951 and element-hq#18951.
* Fix regressed tab view buttons in space update toast ([\element-hq#6761](matrix-org/matrix-react-sdk#6761)). Fixes element-hq#18781 and element-hq#18781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Settings A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
4 participants