-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19036] Discard local SHM locators that cannot be openned #5118
Merged
juanlofer-eprosima
merged 8 commits into
master
from
feature/discard_unrecheable_shm_locators
Aug 6, 2024
Merged
[19036] Discard local SHM locators that cannot be openned #5118
juanlofer-eprosima
merged 8 commits into
master
from
feature/discard_unrecheable_shm_locators
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…king to the NetworkFactory Signed-off-by: eduponz <[email protected]>
…ransports until one reports locator reachability Signed-off-by: eduponz <[email protected]>
…m non-local ports, and shm local ports that cannot open to write Signed-off-by: eduponz <[email protected]>
EduPonz
force-pushed
the
feature/discard_unrecheable_shm_locators
branch
from
July 30, 2024 18:32
44b6103
to
b4833f6
Compare
MiguelCompany
requested changes
Jul 31, 2024
elianalf
force-pushed
the
feature/discard_unrecheable_shm_locators
branch
2 times, most recently
from
July 31, 2024 10:12
d63e7c5
to
3d14ecf
Compare
elianalf
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 31, 2024 10:18
MiguelCompany
requested changes
Jul 31, 2024
elianalf
force-pushed
the
feature/discard_unrecheable_shm_locators
branch
from
July 31, 2024 12:33
87aa5f1
to
92abbd6
Compare
Signed-off-by: elianalf <[email protected]>
MiguelCompany
force-pushed
the
feature/discard_unrecheable_shm_locators
branch
from
July 31, 2024 15:31
92abbd6
to
7e2b522
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 31, 2024 20:40
elianalf
requested review from
Mario-DL
and removed request for
MiguelCompany and
Mario-DL
August 1, 2024 10:24
16 tasks
Mario-DL
force-pushed
the
feature/discard_unrecheable_shm_locators
branch
from
August 2, 2024 11:52
7d9d6b3
to
170e8c4
Compare
We internally agreed to address the convenient changes to overcome the last requirement on a follow up |
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
juanlofer-eprosima
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
is_locator_reachable
API toNetworkFactory
so that unreachable locators can be discarded while deserializing theDATA(p)
,DATA(r)
, orDATA(w)
messages. To do so, theNetworkFactory
iterates over the transports looking for one that can reach the given locator. It does so using a newTransportInterface::is_locator_reachable
API.This PR partially solves a long standing communication issue when the participants are run in the same host but under different users. This used to cause the Fast DDS participants to keep SHM locators from the remote participant that could not be opened (due to permissions); and since Fast DDS limits the communication to SHM as soon as the remote participant has a reachable SHM locator, communication was not possible.
After this PR:
Depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist