Refs #19036: Apply suggestions

Signed-off-by: elianalf <[email protected]>
eProsima · Jul 31, 2024 · 170e8c4 · 170e8c4
1 parent b4833f6
commit 170e8c4
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp b/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp
@@ -454,7 +454,7 @@ bool ParticipantProxyData::readFromCDRMessage(
             [this, &network, &should_filter_locators, source_vendor_id](
         CDRMessage_t* msg, const ParameterId_t& pid, uint16_t plength)
             {
-                static_cast<void>(source_vendor_id);
+                m_VendorId = source_vendor_id;
                 switch (pid){
                     case fastdds::dds::PID_KEY_HASH:
                     {

diff --git a/src/cpp/rtps/builtin/data/ParticipantProxyData.hpp b/src/cpp/rtps/builtin/data/ParticipantProxyData.hpp
@@ -32,6 +32,7 @@
 #include <fastdds/rtps/common/RemoteLocators.hpp>
 #include <fastdds/rtps/common/Token.hpp>
 #include <fastdds/rtps/common/VendorId_t.hpp>
+
 #include <rtps/network/NetworkFactory.hpp>
 
 namespace eprosima {

diff --git a/src/cpp/rtps/builtin/data/ReaderProxyData.cpp b/src/cpp/rtps/builtin/data/ReaderProxyData.cpp
@@ -654,7 +654,7 @@ bool ReaderProxyData::readFromCDRMessage(
     auto param_process = [this, &network, &should_filter_locators, source_vendor_id](
         CDRMessage_t* msg, const ParameterId_t& pid, uint16_t plength)
             {
-                VendorId_t vendor_id = c_VendorId_Unknown;
+                VendorId_t vendor_id = source_vendor_id;
 
                 switch (pid)
                 {

diff --git a/src/cpp/rtps/builtin/data/ReaderProxyData.hpp b/src/cpp/rtps/builtin/data/ReaderProxyData.hpp
@@ -424,7 +424,6 @@ class ReaderProxyData
      * parameter list.
      * @param msg Pointer to the message.
      * @param network Reference to network factory for locator validation and transformation
-     * @param is_shm_transport_available Indicates whether the Reader is reachable by SHM.
      * @param should_filter_locators Whether to retrieve the locators before the external locators filtering
      * @param source_vendor_id VendorId of the source participant from which the message was received
      * @return true on success

diff --git a/src/cpp/rtps/builtin/data/WriterProxyData.cpp b/src/cpp/rtps/builtin/data/WriterProxyData.cpp
@@ -621,7 +621,7 @@ bool WriterProxyData::readFromCDRMessage(
     auto param_process = [this, &network, &should_filter_locators, source_vendor_id](
         CDRMessage_t* msg, const ParameterId_t& pid, uint16_t plength)
             {
-                VendorId_t vendor_id = c_VendorId_Unknown;
+                VendorId_t vendor_id = source_vendor_id;
 
                 switch (pid)
                 {