-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20869] Create DomainParticipantExtendedQos class #4779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciaEchevarria99
changed the title
Feature/extended qos
Create DomainParticipantExtendedQos class
May 14, 2024
LuciaEchevarria99
force-pushed
the
feature/extended_qos
branch
from
May 14, 2024 07:41
ba1f1c2
to
13d6ef8
Compare
This was referenced May 16, 2024
EduPonz
changed the title
Create DomainParticipantExtendedQos class
[20869] Create DomainParticipantExtendedQos class
May 27, 2024
elianalf
suggested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include also a small section in Fast DDS docs in Profile based creation of a DomainParticipant and an example in the Profile based creation of a DomainParticipant
I think that you can complete the Contributor Checklist as follow:
- Any new/modified methods have been properly documented using Doxygen.
- N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
- N/A New feature has been added to the versions.md file (if applicable).
- New feature has been documented/Current behavior is correctly described in the documentation.
- N/A Applicable backports have been included in the description.
include/fastdds/dds/domain/qos/DomainParticipantExtendedQos.hpp
Outdated
Show resolved
Hide resolved
LuciaEchevarria99
force-pushed
the
feature/extended_qos
branch
from
June 5, 2024 09:37
4d0da29
to
5c8a2af
Compare
7 tasks
LuciaEchevarria99
force-pushed
the
feature/extended_qos
branch
from
June 18, 2024 09:20
2714487
to
84521bc
Compare
7 tasks
LuciaEchevarria99
force-pushed
the
feature/extended_qos
branch
2 times, most recently
from
June 19, 2024 13:05
59b340e
to
4638341
Compare
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
…sFromProfile test Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
LuciaEchevarria99
force-pushed
the
feature/extended_qos
branch
from
June 24, 2024 06:55
4638341
to
f4bb27c
Compare
LuciaEchevarria99
requested review from
elianalf
and removed request for
elianalf
June 24, 2024 06:58
Signed-off-by: Lucia Echevarria <[email protected]>
LuciaEchevarria99
requested review from
elianalf
and removed request for
elianalf
June 24, 2024 07:03
EduPonz
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jun 24, 2024
elianalf
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create DomainParticipantExtendedQos class
This PR creates the
DomainParticipantExtendedQos
class, which extends the functionality of the existingDomainParticipantQos
class by adding the domainId member. It also updates theDomainParticipantFactory
to support the creation of participants usingDomainParticipantExtendedQos
.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist