Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect profile loading #156

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix incorrect profile loading #156

merged 1 commit into from
Apr 27, 2022

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Apr 27, 2022

PR #155 added automatic profile loading to the statistics backend. This works, but only when changing Domain IDs. This new PR will allow for profiles to be used for the initial Domain ID selected as well.

@jsan-rt jsan-rt temporarily deployed to codecov April 27, 2022 17:36 Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #156 (e5050fd) into main (b9f0c1c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   57.75%   57.74%   -0.02%     
==========================================
  Files          31       31              
  Lines        4327     4328       +1     
  Branches     2318     2319       +1     
==========================================
  Hits         2499     2499              
  Misses         60       60              
- Partials     1768     1769       +1     
Impacted Files Coverage Δ
src/cpp/StatisticsBackend.cpp 45.45% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f0c1c...e5050fd. Read the comment docs.

@EduPonz EduPonz merged commit 59e750b into main Apr 27, 2022
@EduPonz EduPonz deleted the hotfix/load_default_profiles branch April 27, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants