Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14427] Adds XML profile loading before default qos check #155

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Apr 26, 2022

When using XML Qos configuration, profiles having the is_default_profile tag are not being properly set up as the default Qos to be retrieved with get_default_participant_qos().

This PR should fix that behaviour.

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to update the DomainParticipantFactory mock for this to compile

@jsan-rt jsan-rt temporarily deployed to codecov April 27, 2022 05:45 Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #155 (46cf437) into main (0a90ec7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   57.79%   57.75%   -0.04%     
==========================================
  Files          31       31              
  Lines        4326     4327       +1     
  Branches     2317     2318       +1     
==========================================
- Hits         2500     2499       -1     
  Misses         60       60              
- Partials     1766     1768       +2     
Impacted Files Coverage Δ
src/cpp/StatisticsBackend.cpp 45.58% <0.00%> (-0.14%) ⬇️
src/cpp/database/database_queue.hpp 63.44% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a90ec7...46cf437. Read the comment docs.

@EduPonz EduPonz merged commit b9f0c1c into main Apr 27, 2022
@EduPonz EduPonz deleted the feature/load_default_profiles branch April 27, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants