fix(submission): fix counting and time #969
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -139,10 +133,10 @@ | |||
| return nil, nil, fmt.Errorf("load block: height: %d: %w: %w", newHeight, err, ErrNonRecoverable) | |||
| } else { | |||
| // limit to the max block data, so we don't create a block that is too big to fit in a batch | |||
| maxBlockDataSize := uint64(float64(m.Conf.BlockBatchMaxSizeBytes) * types.MaxBlockSizeAdjustment) | |||
| maxBlockDataSize := uint64(float64(m.Conf.BatchMaxSizeBytes) * types.MaxBlockSizeAdjustment) | |||
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
| go func() { | ||
| err := eg.Wait() | ||
| m.logger.Info("Block manager err group finished.", "err", err) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| uevent.MustPublish(ctx, m.Pubsub, evt, events.HealthStatusList) | ||
|
|
||
| m.logger.Info("Resumed block production.") | ||
| timeLastSubmission = time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| if err != nil { | ||
| return fmt.Errorf("create and submit batch: %w", err) | ||
| } | ||
| timeLastSubmission = time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| go func() { | ||
| bytesProducedC <- nBytes | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #963, #968, #973
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: