Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In AccumulatedDataLoop miscounting - do not assume batches are all BlockBatchMaxSizeBytes size #963

Closed
danwt opened this issue Jul 18, 2024 · 0 comments · Fixed by #969
Closed
Assignees

Comments

@danwt
Copy link
Contributor

danwt commented Jul 18, 2024

Even after

which fix

there is still a problem:

The AccumulatedDataLoop basically assumes that the size of the batch being submitted is equal to BlockBatchMaxSizeBytes but actually it will be less. That means every time the submission happens it is actually falling more and more behind the actual produced blocks.

@danwt danwt changed the title In AccumulatedDataLoop do not assume batches are all BlockBatchMaxSizeBytes size In AccumulatedDataLoop miscounting - do not assume batches are all BlockBatchMaxSizeBytes size Jul 18, 2024
@danwt danwt self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant