Added in resistance reporting for a lot of bikes #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Added a check to stop automatic scanning if both devices are connected. Fixed bug submitted by @Flo100 where MIN_WATTS in ERG should have been userConfig.getMinWatts(); Co-Authored-By: Flo100 <[email protected]>
This reverts commit b6a77f4.
Changed < and > to <= and >= in line 273 and 274 below so it doesn't switch when it is already on min or max resistance.
|
@eMadman - Requesting final review and approval. I think it's ready. |
eMadman
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in reading resistance from Echelon, Flywheel and Peloton (and any others that send this data via FTMS) and then outputting that resistance via FTMS server. Needs through testing. Very many files touched.