Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microsoft-spark JARs to include Scala version #728

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

imback82
Copy link
Contributor

@imback82 imback82 commented Oct 9, 2020

Fixes #293

This PR proposes to include Scala version in the JAR name (in preparation for publishing these to the central repository) following the similar approach taken by Spark: https://github.com/apache/spark/blob/master/external/kafka-0-10/pom.xml

@imback82 imback82 self-assigned this Oct 9, 2020
@imback82 imback82 added the enhancement New feature or request label Oct 9, 2020
@imback82 imback82 added this to the 1.0.0 milestone Oct 9, 2020
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @imback82 !

@imback82 imback82 merged commit 80c745b into dotnet:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Show Scala version in microsoft-spark*.jar filename
2 participants