Skip to content

Commit

Permalink
Update microsoft-spark JARs to include Scala version (#728)
Browse files Browse the repository at this point in the history
  • Loading branch information
imback82 authored Oct 9, 2020
1 parent 2a6479d commit 80c745b
Show file tree
Hide file tree
Showing 52 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions src/csharp/Microsoft.Spark.E2ETest/SparkFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ private void BuildSparkCmd(out string filename, out string args)
string scalaDir = Path.Combine(curDir, "..", "..", "..", "..", "..", "src", "scala");
string jarDir = Path.Combine(scalaDir, jarPrefix, "target");
string assemblyVersion = Assembly.GetExecutingAssembly().GetName().Version.ToString(3);
string jar = Path.Combine(jarDir, $"{jarPrefix}-{assemblyVersion}.jar");
string scalaVersion = (SparkSettings.Version.Major == 3) ? "2.12" : "2.11";
string jar = Path.Combine(jarDir, $"{jarPrefix}_{scalaVersion}-{assemblyVersion}.jar");

if (!File.Exists(jar))
{
Expand Down Expand Up @@ -180,7 +181,7 @@ private void BuildSparkCmd(out string filename, out string args)
private string GetJarPrefix()
{
Version sparkVersion = SparkSettings.Version;
return $"microsoft-spark-{sparkVersion.Major}.{sparkVersion.Minor}.x";
return $"microsoft-spark-{sparkVersion.Major}-{sparkVersion.Minor}";
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<artifactId>microsoft-spark</artifactId>
<version>${microsoft-spark.version}</version>
</parent>
<artifactId>microsoft-spark-2.3.x</artifactId>
<artifactId>microsoft-spark-2-3_2.11</artifactId>
<inceptionYear>2019</inceptionYear>
<properties>
<encoding>UTF-8</encoding>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<artifactId>microsoft-spark</artifactId>
<version>${microsoft-spark.version}</version>
</parent>
<artifactId>microsoft-spark-2.4.x</artifactId>
<artifactId>microsoft-spark-2-4_2.11</artifactId>
<inceptionYear>2019</inceptionYear>
<properties>
<encoding>UTF-8</encoding>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<artifactId>microsoft-spark</artifactId>
<version>${microsoft-spark.version}</version>
</parent>
<artifactId>microsoft-spark-3.0.x</artifactId>
<artifactId>microsoft-spark-3-0_2.12</artifactId>
<inceptionYear>2019</inceptionYear>
<properties>
<encoding>UTF-8</encoding>
Expand Down
6 changes: 3 additions & 3 deletions src/scala/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
</properties>

<modules>
<module>microsoft-spark-2.3.x</module>
<module>microsoft-spark-2.4.x</module>
<module>microsoft-spark-3.0.x</module>
<module>microsoft-spark-2-3</module>
<module>microsoft-spark-2-4</module>
<module>microsoft-spark-3-0</module>
</modules>

<pluginRepositories>
Expand Down

0 comments on commit 80c745b

Please sign in to comment.