-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More ValueOption in compiler: part 3 (and the last) #16822
Conversation
❗ Release notes required
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl
Outdated
Show resolved
Hide resolved
This reverts commit 948b8c3.
tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/ValueOptionBenchmarks.fs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to wait with this one for now, since now we're having some live issues with SO
I've merged couple of fixes and workarounds for the SOs in CEs and in big nested expressions. We can probably merge this one (extra would be to test AnyCpu variant on those). |
These performance improvements are quite impressive and more than I'd expect from such change. Nice! |
Closes #16286
If my RegEx is correct, this should be it.
Some benchmarks (for what was easy to bench):
Before:
After: