Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSharp.Core package versions aren't incrementing with each SDK release #16014

Closed
baronfel opened this issue Sep 21, 2023 · 5 comments · Fixed by #16015
Closed

FSharp.Core package versions aren't incrementing with each SDK release #16014

baronfel opened this issue Sep 21, 2023 · 5 comments · Fixed by #16015
Labels
Area-Infrastructure Bug Engineering Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Milestone
Backlog

Comments

@baronfel
Copy link
Member

The FSharp.Core packages aren't revving with associated SDK/runtime revisions on a monthly cadence. This means that folks using tools like NuGet's lock files can get content hash errors.

A sample of the currently-published versions:

image

What I note here is that there were 6.0.x versions that were being pushed, but in the 7.x series and onwards we lost this.
@github-actions github-actions bot added this to the Backlog milestone Sep 21, 2023
@vzarytovskii
Copy link
Member

We usually bump it/can catch it in CI only if we make changes after previous version got released. So if there were no changes, we won't bump it.

@baronfel
Copy link
Member Author

So for 400 specifically @nojaf and @dawedawe are seeing content hash problems: https://github.com/ionide/FSharp.Analyzers.SDK/actions/runs/6258508516/job/17006020981

I don't know if this means there was a change or not that was missed?

@KevinRansom KevinRansom mentioned this issue Sep 21, 2023
Merged
@0101 0101 added Engineering Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Area-Infrastructure and removed Needs-Triage labels Sep 25, 2023
dawedawe added a commit to dawedawe/FSharp.Analyzers.SDK that referenced this issue Sep 26, 2023
@dawedawe
remove packages.lock.json files till we have a fixed sdk
28712c9 
see dotnet/fsharp#16014 and dotnet/fsharp#16015
@dawedawe dawedawe mentioned this issue Sep 26, 2023
Merged
dawedawe added a commit to G-Research/fsharp-analyzers that referenced this issue Sep 26, 2023
@dawedawe
remove packages.lock.json files till we have a fixed sdk
d588d8b 
see dotnet/fsharp#16014 and dotnet/fsharp#16015
dawedawe added a commit to G-Research/fsharp-analyzers that referenced this issue Sep 26, 2023
@dawedawe
Remove packages lock files (#6)
2977386 
* remove packages.lock.json files till we have a fixed sdk
see dotnet/fsharp#16014 and dotnet/fsharp#16015

* set RestorePackagesWithLockFile and RestoreLockedMode to false in Directory.Build.props
remove doubled RestorePackagesWithLockFile entry in Directory.Packages.props

* adjust to latest master in SDK

* Revert "adjust to latest master in SDK"

This reverts commit a4b635e.

* switch to the package references

* remove build of SDK from ci.yml
@nojaf
Copy link
Contributor

nojaf commented Oct 3, 2023

As this very much is a problem and we had to resolve to not using lock files, will there be a 7.0.401 with the fix?

@vzarytovskii
Copy link
Member

As this very much is a problem and we had to resolve to not using lock files, will there be a 7.0.401 with the fix?

If it gets inserted in sdk, then yes. So far it wasn't: dotnet/sdk#35666

This was referenced Oct 6, 2023
Merged
Closed
Merged
@nojaf
Copy link
Contributor

nojaf commented Feb 1, 2024

We no longer have this problem.

@nojaf nojaf closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Infrastructure Bug Engineering Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix16014 - Update package versions for fsharp.core and fsharp.compiler.service KevinRansom/fsharp
4 participants
@0101 @baronfel @vzarytovskii @nojaf