Remove packages lock files (#6)

* remove packages.lock.json files till we have a fixed sdk
see dotnet/fsharp#16014 and dotnet/fsharp#16015

* set RestorePackagesWithLockFile and RestoreLockedMode to false in Directory.Build.props
remove doubled RestorePackagesWithLockFile entry in Directory.Packages.props

* adjust to latest master in SDK

* Revert "adjust to latest master in SDK"

This reverts commit a4b635e.

* switch to the package references

* remove build of SDK from ci.yml

.github/workflows/ci.yml

@@ -14,26 +14,10 @@ jobs:
   ci:
     runs-on: ubuntu-latest
     steps:
-      # Ionide SDK
-      - name: Checkout ionide/FSharp.Analyzers.SDK
-        uses: actions/checkout@v3
-        with:
-          repository: ionide/FSharp.Analyzers.SDK
-          path: FSharp.Analyzers.SDK
-          ref: master
-      - name: Setup .NET for ionide/FSharp.Analyzers.SDK
-        uses: actions/setup-dotnet@v3
-        with: 
-          global-json-file: FSharp.Analyzers.SDK/global.json
-      - name: Build ionide/FSharp.Analyzers.SDK
-        working-directory: FSharp.Analyzers.SDK
-        run: dotnet fsi build.fsx
-
-      # G-Research analyzers
       - uses: actions/checkout@v3
         with:
           path: g-research-fsharp-analyzers
-      - name: Setup .NET for ionide/FSharp.Analyzers.SDK
+      - name: Setup .NET
         uses: actions/setup-dotnet@v3
         with:
           global-json-file: g-research-fsharp-analyzers/global.json

Directory.Build.props

@@ -21,8 +21,8 @@ F# analyzers used within G-Research.
         <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
         <WarningsAsErrors>FS0025</WarningsAsErrors>
         <WarnOn>1182;3390;$(WarnOn)</WarnOn>
-        <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
-        <RestoreLockedMode>true</RestoreLockedMode>
+        <RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>
+        <RestoreLockedMode>false</RestoreLockedMode>
         <NoWarn>NU1603;NETSDK1057</NoWarn>
         <DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
         <!-- https://www.gresearch.co.uk/blog/article/improve-nuget-restores-with-static-graph-evaluation/ -->

Directory.Packages.props

@@ -1,11 +1,12 @@
 <Project>
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
   </PropertyGroup>
   <ItemGroup>
     <!-- locking the version of F# Core as FCS does this anyway and in practise all will be using the same version -->
+    <PackageVersion Include="FSharp.Analyzers.SDK" Version="0.14.1" />
+    <PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="0.14.1" />
     <PackageVersion Include="FSharp.Core" Version="[7.0.400]" />
     <PackageVersion Include="FSharp.Compiler.Service" Version="[43.7.400]" />
     <PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" />

src/FSharp.Analyzers/FSharp.Analyzers.fsproj

@@ -13,12 +13,9 @@
         <Compile Include="StringAnalyzers.fs"/>
     </ItemGroup>
 
-    <ItemGroup>
-        <ProjectReference Include="..\..\..\FSharp.Analyzers.SDK\src\FSharp.Analyzers.SDK\FSharp.Analyzers.SDK.fsproj"/>
-    </ItemGroup>
-
     <ItemGroup>
         <PackageReference Update="FSharp.Core"/>
+        <PackageReference Include="FSharp.Analyzers.SDK" />
         <PackageReference Include="FSharp.Compiler.Service"/>
     </ItemGroup>