Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken .NET 9 dependencies link #9475

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

MichaelSimons
Copy link
Member

This is fallout from the changes made in #9412.

@MichaelSimons
Copy link
Member Author

@jongalloway, since you enabled the MD linter, is there an effort to proactively ensure all the markdown is valid in the repo so that contributions like this don't fail CI when they touch Markdown files that contain existing syntax issues?

@MichaelSimons
Copy link
Member Author

@richlander, @mairaw - when the markdown-link-check GH action was added, is there a particular reason why the check-modified-files-only was turned on? This is the reason this regression was not caught. There can be other situation where changes outside the repo can cause a link break. We should be catching those proactively IMO.

@jongalloway
Copy link
Contributor

@jongalloway, since you enabled the MD linter, is there an effort to proactively ensure all the markdown is valid in the repo so that contributions like this don't fail CI when they touch Markdown files that contain existing syntax issues?

Yes, @richlander asked me to set up markdown linting to ensure valid and quality markdown. I don't think we have link checking enabled, and don't know if that's a feature of the linter we're using.

@mairaw
Copy link
Contributor

mairaw commented Aug 21, 2024

We do have link checking enabled with the markdown-link-check that I added a while back. But I think only I pay attention to those and now I know you do too @MichaelSimons. I probably added that setting so folks working on different files wouldn't get errors on changes that have nothing to do with their PR. But if you want to enable a full scan, you can change that setting. I cleaned up a lot of broken links on this repo over time, so hopefully it wouldn't be too bad to enable that now.

@MichaelSimons
Copy link
Member Author

Yes, @richlander asked me to set up markdown linting to ensure valid and quality markdown. I don't think we have link checking enabled, and don't know if that's a feature of the linter we're using.

I was only asking about the markdown linter. There is already a GH action that verifies the links.

The way the super linter is configured, it will only run on the modified code because of the VALIDATE_ALL_CODEBASE: false setting. There is a potential for numerous syntax issues in the existing codebase. My question is if anyone is going to proactively address those? If not any contributor is going to have to fix them whenever they touch a file with pre-existing syntax issues

@MichaelSimons MichaelSimons merged commit a0703e1 into main Aug 22, 2024
5 checks passed
@MichaelSimons MichaelSimons deleted the MichaelSimons-patch-1 branch August 22, 2024 18:58
@mairaw
Copy link
Contributor

mairaw commented Aug 22, 2024

And there will be many because I have local linter on my files and it's always complaining about linting issues on dotnet/core. I think as long as it's not enforced like the link check doesn't prevent you from merging even if it doesn't pass, it should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants