-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken .NET 9 dependencies link #9475
Conversation
@jongalloway, since you enabled the MD linter, is there an effort to proactively ensure all the markdown is valid in the repo so that contributions like this don't fail CI when they touch Markdown files that contain existing syntax issues? |
@richlander, @mairaw - when the markdown-link-check GH action was added, is there a particular reason why the |
Yes, @richlander asked me to set up markdown linting to ensure valid and quality markdown. I don't think we have link checking enabled, and don't know if that's a feature of the linter we're using. |
We do have link checking enabled with the markdown-link-check that I added a while back. But I think only I pay attention to those and now I know you do too @MichaelSimons. I probably added that setting so folks working on different files wouldn't get errors on changes that have nothing to do with their PR. But if you want to enable a full scan, you can change that setting. I cleaned up a lot of broken links on this repo over time, so hopefully it wouldn't be too bad to enable that now. |
I was only asking about the markdown linter. There is already a GH action that verifies the links. The way the super linter is configured, it will only run on the modified code because of the |
And there will be many because I have local linter on my files and it's always complaining about linting issues on dotnet/core. I think as long as it's not enforced like the link check doesn't prevent you from merging even if it doesn't pass, it should be ok. |
This is fallout from the changes made in #9412.