Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action to check links in md files #8346

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Add GH action to check links in md files #8346

merged 9 commits into from
Apr 4, 2023

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 1, 2023

@krwq I saw your comment about link checking at #8300 (comment)

Perhaps a GH action could work on this repo. I configured to only run on the modified files. I'll have a separate PR to fix some links.

@mairaw mairaw requested review from richlander and jongalloway April 4, 2023 02:29
Copy link
Contributor

@jongalloway jongalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good find!

@mairaw mairaw merged commit 829788e into main Apr 4, 2023
@mairaw mairaw deleted the markdown-link-check branch April 4, 2023 17:11
@krwq
Copy link
Member

krwq commented Apr 5, 2023

I like the way you set it up! I'm not much familiar with actions but I think we will investigate and do it similarly. I've opened dotnet/iot#2065 on our side since we're getting some noise with external URLs (we have lots of links to external specs and some manufacturers change link on every update)

@mairaw
Copy link
Contributor Author

mairaw commented Apr 5, 2023

I made some tweaks to the syntax since the merge. Testing it out as we go 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants