-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tree root #1877
Feature/tree root #1877
Conversation
fix operator precedence remove debug info update repository to use identifierMethod for TreeRoot fix parenthesis
Oh yeah, i also changed to PSR-4, and moved the source code to the |
I tidied up the pull request, code is back in the lib folder so you should be able to review changes easily now :-) |
yes, I would not accept the could you also add a unit test for this new feature? |
Yeah sure, I can't do it today, but I'll work on it and give you another shout. Regarding the lib folder, we are now on PSR-4 anyway 😃 (just not in |
Hi @l3pp4rd I have tested the new functionality and updated the |
thanks for all the effort, hope it will be useful for all users ;) |
Hello, I don't see any example in the documentation about having several root, I want to make a system as Wordpress has, what is called Taxonomy, I have seen that in Laravel there are many libraries, but in Symfony none :( |
Now I have set
@Gedmo\TreeRoot(identifierMethod="getMenu")
, so it can restrict and renumber by the rows with a menu_id of x (the real tree root, a row in another table).After running the repository method
moveUp(7)
(the action movie category, in the above example, third out of 3 movie categories), instead of an exception being thrown, now we get: