Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuBundle] Override Gedmo to allow multiple tree roots on menu_id c… #1812

Closed
wants to merge 1 commit into from

Conversation

delboy1978uk
Copy link
Contributor

@delboy1978uk delboy1978uk commented Feb 8, 2018

…olumn

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets #1811

@delboy1978uk
Copy link
Contributor Author

delboy1978uk commented Feb 9, 2018

This causes a BC break - Devs must set the gedmo listener to our one :

gedmo.listener.tree:
        class: Kunstmaan\MenuBundle\EventListener\TreeListener
        tags:
            - { name: doctrine.event_subscriber, connection: default }
        calls:
            - [ setAnnotationReader, [ "@annotation_reader" ] ]

@Numkil says we can set this in the skeleton app so future installs will work without needing to change anything.

@delboy1978uk
Copy link
Contributor Author

Hello! I didn't want to break the bundles, so I tweaked our changes and made a pull request on the actual package doctrine-extensions/DoctrineExtensions#1877

Copy link

@Numkil Numkil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for response on the gedmo PR first

@Numkil
Copy link

Numkil commented Jul 31, 2018

Problem was solved in the gedmo repository so no need to do it here anymore.

@Numkil Numkil closed this Jul 31, 2018
@acrobat
Copy link
Member

acrobat commented Aug 2, 2018

@Numkil I think the only change we still need of the PR is the @Gedmo\TreeRoot annotation on the menu propery. https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1812/files#diff-c4c919080101e87060c1cfef3bf34597R37

And maybe set the minimum version for gedmo on the version with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants