Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made favicon meta tags conform to specs. #6025

Merged
merged 2 commits into from
May 3, 2024
Merged

Made favicon meta tags conform to specs. #6025

merged 2 commits into from
May 3, 2024

Conversation

Mostafa-Moafi
Copy link
Contributor

Fix #6011: Non conforming favicon meta tags

bdukes
bdukes approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdukes bdukes added this to the 9.13.4 milestone May 3, 2024
valadas
valadas approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, since we are here, should we also lowercase it ?

@Mostafa-Moafi
Copy link
Contributor Author

Mostafa-Moafi commented May 3, 2024 •
edited
Loading

looks good, since we are here, should we also lowercase it ?

I fixed it because it's recommended to use lowercase for HTML tags and attributes for consistency and readability. However, browsers are generally not case-sensitive when it comes to parsing HTML.

@bdukes bdukes merged commit adf7f64 into dnnsoftware:develop May 3, 2024
3 checks passed
@valadas valadas changed the title Fix #6011: Non conforming favicon meta tags Made favicon meta tags conform to specs. Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes bdukes approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.13.4
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Non conforming favicon meta tags
3 participants
@Mostafa-Moafi @bdukes @valadas