Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Non conforming favicon meta tags #6011

Closed
2 of 4 tasks
fcmss opened this issue Apr 24, 2024 · 0 comments · Fixed by #6025
Closed
2 of 4 tasks

[Enhancement]: Non conforming favicon meta tags #6011

fcmss opened this issue Apr 24, 2024 · 0 comments · Fixed by #6025

Comments

@fcmss
Copy link

fcmss commented Apr 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

In current DNN version, the favicon meta tags uses <link rel="SHORTCUT ICON" href="[FAVICON LINK]" type="image/x-icon"> which is incorrect according to MDN website:

Note

Note: The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore.

Description of solution

Solution is relatively simple, unless DNN somehow relies on the rel="SHORTCUT ICON", but the solution is just to change it to rel="icon" or rel="icon shortcut".

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant