KinematicCharacterController: early break in move_shape in case of no update. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebcrozet hi, you asked me to send a simple example of the problem that patch should solve on Discord, so here it is 🙂 : simpletest.zip. Please notice also that I would expect grounded to become |
If no movements are performed in an iteration of move_shape, early break, instead of trying to repeat it again.
PieroV
force-pushed
the
kcc-no-update-break
branch
from
e072ea0 to
ea19166
Compare
Vrixyz
added
2D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I think the
whileinmove_shapecould be early-broken if no improvement is done in an iteration: if I understand correctly, if the character has not moved in an iteration, it will not in the next one, too.However, all the collision queries will be run, consuming time.
But I am not sure this makes sense, since
kinematic_friction_translationis also updated during iterations.