Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay import of scipy until needed. #196

Closed
wants to merge 1 commit into from
Closed

Delay import of scipy until needed. #196

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 27, 2020 •
edited
Loading

As suggested in #194 (comment).

Edit: looks like there's some failure with the mocking of lapack :/

@anntzer anntzer force-pushed the delayscipy branch 3 times, most recently from 9508b7a to d7f627e Compare January 27, 2020 18:21
@dhermes dhermes mentioned this pull request Jan 28, 2020
Merged
dhermes added a commit that referenced this pull request Jan 28, 2020
@dhermes
Moving scipy imports to happen at runtime.
38602d8 
Follows along approach from previous commit and earlier work
in #194, #195. This supercedes #196.

This also fixes a "SympPy" -> "SymPy" typo from the previous commit.
@dhermes
Copy link
Owner

dhermes commented Jan 28, 2020

Closing due to 38602d8 and discussion in #194.

@dhermes dhermes closed this Jan 28, 2020
@dhermes dhermes self-requested a review January 28, 2020 05:41
@dhermes dhermes self-assigned this Jan 28, 2020
@anntzer anntzer deleted the delayscipy branch January 28, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes Awaiting requested review from dhermes

Assignees

@dhermes dhermes

Labels
language: python packaging performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @dhermes