Delay import of pkg_resources until needed (if ever). #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources can be very slow to import. Alternatively, one could use importlib.resources on Py3.7+, but then one needs to add version-conditional code for Py3.6 (or a version-conditional dependency on importlib_resources).
anntzer
force-pushed
the
delay-pkg_resources
branch
from
69900ea to
1fcc015
Compare
|
LGTM. Looks like I've gotta update the coveralls job to only work on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources can be very slow to import (e.g. pypa/setuptools#926).
See rationale re: importance of import time in #194.
Alternatively, one could use importlib.resources on Py3.7+, but
then one needs to add version-conditional code for Py3.6 (or a
version-conditional dependency on importlib_resources).