Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IBC ante handler #717

Merged
merged 7 commits into from
Jan 11, 2022
Merged

feat: add IBC ante handler #717

merged 7 commits into from
Jan 11, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 10, 2022

Description

This PR adds the IBC AnteHandler to the list of ante handlers. Closes #714

Depends-On: #716


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Jan 10, 2022
@RiccardoM RiccardoM changed the title feat: added IBC ante handler feat: add IBC ante handler Jan 10, 2022
@RiccardoM RiccardoM requested review from leobragaz and dadamu January 10, 2022 10:48
Signed-off-by: Riccardo Montagnin <[email protected]>
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #717 (e438557) into master (fa91180) will decrease coverage by 0.10%.
The diff coverage is 72.09%.

❗ Current head e438557 differs from pull request most recent head 4ddad0a. Consider uploading reports for the commit 4ddad0a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   79.10%   78.99%   -0.11%     
==========================================
  Files          52       53       +1     
  Lines        4201     4237      +36     
==========================================
+ Hits         3323     3347      +24     
- Misses        711      719       +8     
- Partials      167      171       +4     
Impacted Files Coverage Δ
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/keeper/relay_app_links.go 86.81% <ø> (ø)
x/profiles/types/genesis.go 94.73% <ø> (ø)
x/profiles/types/msgs_app_links.go 87.32% <ø> (ø)
app/ante.go 63.63% <63.63%> (ø)
app/app.go 81.49% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa91180...4ddad0a. Read the comment docs.

@github-actions github-actions bot removed the kind/ci Improve the CI/CD label Jan 10, 2022
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 10, 2022
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything good 👍

@mergify mergify bot merged commit d21bce2 into master Jan 11, 2022
@mergify mergify bot deleted the riccardo/add-ibc-ante-handler branch January 11, 2022 03:53
@github-actions github-actions bot removed x/CLI kind/build Related to the build of the project x/profiles Module that allows to create and manage decentralized social profiles labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IBC AnteHandler
3 participants