Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/cosmos/ibc-go from v1.2.3 to v2.0.2 #716

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 10, 2022

Description

This PR updates IBC to v2.0.2. Closes #715

Depends-On: #718


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 10, 2022
@RiccardoM RiccardoM requested review from dadamu and leobragaz January 10, 2022 10:18
@github-actions github-actions bot added kind/build Related to the build of the project x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Jan 10, 2022
Signed-off-by: Riccardo Montagnin <[email protected]>
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #716 (be1209c) into master (db042cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files          52       52           
  Lines        4201     4201           
=======================================
  Hits         3323     3323           
  Misses        711      711           
  Partials      167      167           
Impacted Files Coverage Δ
app/app.go 81.34% <ø> (ø)
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/keeper/relay_app_links.go 86.81% <ø> (ø)
x/profiles/types/genesis.go 94.73% <ø> (ø)
x/profiles/types/msgs_app_links.go 87.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cc187...be1209c. Read the comment docs.

@github-actions github-actions bot added the kind/ci Improve the CI/CD label Jan 10, 2022
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM force-pushed the riccardo/update-ibc branch from 6c73a4e to 64c6821 Compare January 10, 2022 10:40
@RiccardoM RiccardoM mentioned this pull request Jan 10, 2022
19 tasks
@RiccardoM RiccardoM removed the automerge Automatically merge PR once all prerequisites pass label Jan 10, 2022
@github-actions github-actions bot removed the kind/ci Improve the CI/CD label Jan 10, 2022
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 10, 2022
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mergify mergify bot merged commit fa91180 into master Jan 10, 2022
@mergify mergify bot deleted the riccardo/update-ibc branch January 10, 2022 13:24
mergify bot pushed a commit that referenced this pull request Jan 11, 2022
## Description
This PR adds the IBC `AnteHandler` to the list of ante handlers. Closes #714

Depends-On: #716

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/build Related to the build of the project x/CLI x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade IBC to v2
3 participants