Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADR-008: Change the plain text encoding of links to hex #652

Merged
merged 7 commits into from
Oct 15, 2021

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Oct 15, 2021

Description

This PR implements what's described inside ADR-008.
Closes: #636


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #652 (5b32554) into master (d6e42b6) will decrease coverage by 68.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #652       +/-   ##
===========================================
- Coverage   83.79%   15.70%   -68.09%     
===========================================
  Files          91      168       +77     
  Lines        6663    45945    +39282     
===========================================
+ Hits         5583     7215     +1632     
- Misses        866    38115    +37249     
- Partials      214      615      +401     
Impacted Files Coverage Δ
app/app.go 77.70% <ø> (ø)
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/client/cli/cli_dtag_requests.go 81.89% <ø> (ø)
x/profiles/client/cli/cli_params.go 70.00% <ø> (ø)
x/profiles/client/cli/cli_profile.go 85.36% <ø> (ø)
x/profiles/client/cli/cli_relationships.go 75.51% <ø> (ø)
x/profiles/client/cli/query.go 0.00% <ø> (ø)
x/profiles/client/cli/tx.go 0.00% <ø> (ø)
x/profiles/client/utils/cli.pb.go 3.12% <ø> (ø)
x/profiles/client/utils/utils.go 56.25% <ø> (ø)
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ad022...5b32554. Read the comment docs.

@dadamu dadamu changed the title feat: ADR-008 implementation: Change the plain text encoding of links to hex feat: ADR-008: Change the plain text encoding of links to hex Oct 15, 2021
@dadamu dadamu requested review from RiccardoM and leobragaz October 15, 2021 06:36
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@@ -87,7 +87,7 @@ func TestGetCreateChainLinkJSON(t *testing.T) {
profilestypes.NewProof(
key.GetPubKey(),
"c3bd014b2178d63d94b9c28e628bfcf56736de28f352841b0bb27d6fff2968d62c13a10aeddd1ebfe3b13f3f8e61f79a2c63ae6ff5cb78cb0d64e6b0a70fae57",
"cosmos13j7p6faa9jr8ty6lvqv0prldprr6m5xenmafnt"),
"636f736d6f7331336a377036666161396a72387479366c7671763070726c64707272366d3578656e6d61666e74"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tip for reviewers: you can use this tool to check that the previous value (cosmos13j7p6faa9jr8ty6lvqv0prldprr6m5xenmafnt) corresponds to the now HEx-encoded one (636f736d6f7331336a377036666161396a72387479366c7671763070726c64707272366d3578656e6d61666e74).

@RiccardoM
Copy link
Contributor

Can you just add a changeset entry @dadamu please? I think you can update the changeset command and then you should be able to add it properly

@dadamu
Copy link
Contributor Author

dadamu commented Oct 15, 2021

@RiccardoM changeset added.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Oct 15, 2021
@mergify mergify bot merged commit dd2162e into master Oct 15, 2021
@mergify mergify bot deleted the paul/adr-008-impl branch October 15, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the app link signature encoding to hex
3 participants