-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ADR-008: Change the plain text encoding of links to hex #652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
===========================================
- Coverage 83.79% 15.70% -68.09%
===========================================
Files 91 168 +77
Lines 6663 45945 +39282
===========================================
+ Hits 5583 7215 +1632
- Misses 866 38115 +37249
- Partials 214 615 +401
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
@@ -87,7 +87,7 @@ func TestGetCreateChainLinkJSON(t *testing.T) { | |||
profilestypes.NewProof( | |||
key.GetPubKey(), | |||
"c3bd014b2178d63d94b9c28e628bfcf56736de28f352841b0bb27d6fff2968d62c13a10aeddd1ebfe3b13f3f8e61f79a2c63ae6ff5cb78cb0d64e6b0a70fae57", | |||
"cosmos13j7p6faa9jr8ty6lvqv0prldprr6m5xenmafnt"), | |||
"636f736d6f7331336a377036666161396a72387479366c7671763070726c64707272366d3578656e6d61666e74"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tip for reviewers: you can use this tool to check that the previous value (cosmos13j7p6faa9jr8ty6lvqv0prldprr6m5xenmafnt
) corresponds to the now HEx-encoded one (636f736d6f7331336a377036666161396a72387479366c7671763070726c64707272366d3578656e6d61666e74
).
Can you just add a |
@RiccardoM changeset added. |
Description
This PR implements what's described inside ADR-008.
Closes: #636
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change