docs(adr): ADR-008: Change the plain text encoding of links to hex #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind/adr
dadamu
changed the title
RiccardoM
reviewed
Oct 7, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
leobragaz
reviewed
Oct 7, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
leobragaz
reviewed
Oct 8, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
RiccardoM
reviewed
Oct 10, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
RiccardoM
reviewed
Oct 12, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
…inks-to-hex.md Co-authored-by: Riccardo Montagnin <[email protected]>
leobragaz
reviewed
Oct 13, 2021
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-008-change-the-plain-text-encoding-the-links-to-hex.md
Outdated
Show resolved
Hide resolved
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
…inks-to-hex.md Co-authored-by: Leonardo Bragagnolo <[email protected]>
leobragaz
approved these changes
Oct 13, 2021
RiccardoM
approved these changes
Oct 14, 2021
mergify
bot
deleted the
paul/adr-008-change-the-link-signature-encoding-to-hex
branch
19 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
## Description This PR implements what's described inside [ADR-008](#642). Closes: #636 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the draft of the 8th ADR related to Change the plain text encoding of links to hex in #636.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change