Added automatic testnet command #42
Conversation
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: RiccardoM <[email protected]>
RiccardoM
added
the
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## develop #42 +/- ##
========================================
Coverage 81.47% 81.47%
========================================
Files 13 13
Lines 502 502
========================================
Hits 409 409
Misses 84 84
Partials 9 9Continue to review full report at Codecov.
|
README.md
Outdated
| #### Configuration | ||
|
|
||
| The `make localnet-start` creates files for a 4-node testnet in `./build` by | ||
| calling the `demosd testnet` command. This outputs a handful of files in the |
There was a problem hiding this comment.
Fixed, thanks for the heads up
networks/local/Makefile
Outdated
| # Makefile for the "desmosd" docker image. | ||
|
|
||
| all: | ||
| docker build --tag desmos-labs/desmosdnode desmosdnode |
There was a problem hiding this comment.
The organization I created on Docker Hub is desmoslabs (https://hub.docker.com/orgs/desmoslabs). I think the tag has to be desmoslabs/desmosdnode here.
There was a problem hiding this comment.
I got this error
docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"/usr/bin/wrapper.sh\": permission denied": unknown.
when I run the command. Maybe some setup in the docker file. I don't get this error in gaia local testnet.
- Fixed some typo into the README - Updated the chmod index of wrapper.sh - Updated the Docker image organization name Signed-off-by: RiccardoM <[email protected]>
There was a problem hiding this comment.
I got this error
docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"/usr/bin/wrapper.sh\": permission denied": unknown.when I run the command. Maybe some setup in the docker file. I don't get this error in gaia local testnet.
I think it was due to a missing execute permission on the file. I've updated the index adding chmod=+x and should work properly now
There was a problem hiding this comment.
It's still not working with the permission denied error. I don't understand why the permission is not preserved. I tried adding RUN chmod +x /usr/bin/wrapper.sh to the Dockerfile before and after the ENTREPOINT but still not working.
Actually this doesn't affect the functionality of the node. We can still merge this and #44 and tag our v0.1.0 for testnet and revisit this again later. What do you think?
|
Yeah I'm fine with merging this and opening an issue for the specific error |
Description
Added the
localnet-startandlocalnet-stopcommands which allow to create a local 4-node testnet using a Docker image.Taken and adapted from the gaia repo.
Closes #33
Checklist
Files changedin the Github PR explorer