Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile improvements #44

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Makefile improvements #44

merged 3 commits into from
Nov 21, 2019

Conversation

RiccardoM
Copy link
Contributor

Description

Improved how Makefile is written, including the contrib/devtools Makefile which allows for easy golangci-lint tools to be downloaded and installed.

Checklist

  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Re-reviewed Files changed in the Github PR explorer

@RiccardoM RiccardoM added the kind/enhancement Enhance an already existing feature; no "New feature" to add label Nov 20, 2019
@RiccardoM RiccardoM requested a review from kwunyeung November 20, 2019 07:49
@codecov-io
Copy link

Codecov Report

Merging #44 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #44   +/-   ##
========================================
  Coverage    81.47%   81.47%           
========================================
  Files           13       13           
  Lines          502      502           
========================================
  Hits           409      409           
  Misses          84       84           
  Partials         9        9
Impacted Files Coverage Δ
x/magpie/internal/types/msgs.go 96% <ø> (ø) ⬆️
x/posts/internal/keeper/keeper.go 100% <ø> (ø) ⬆️
x/posts/internal/types/post.go 4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7e035...eb4859b. Read the comment docs.

@RiccardoM RiccardoM mentioned this pull request Nov 20, 2019
4 tasks
@kwunyeung kwunyeung merged commit d3f8199 into develop Nov 21, 2019
@RiccardoM RiccardoM deleted the riccardo/makefile-improvements branch November 21, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants