-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FUTURE(ext/net): remove Deno.ListenTlsOptions.(keyFile|certFile)
#23271
Conversation
This passes on my local machine. Not sure why it's failing in CI. |
Signed-off-by: Asher Gomez <[email protected]>
@mmastrac, I'm setting the deprecated cert and key properties to Line 452 in 9304126
op_tls_key_null() in loadTlsKeyPair() , we could throw some error saying that none of the cert or key properties aren't defined but need to be. This will also affect #23270.
|
Signed-off-by: Asher Gomez <[email protected]>
Deno.ListenTlsOptions.(keyFile|certFile)
illegalDeno.ListenTlsOptions.(keyFile|certFile)
Signed-off-by: Asher Gomez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase
Signed-off-by: Asher Gomez <[email protected]>
Towards #23089