Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: remove APIs using DENO_FUTURE=1 #23089

Closed
7 of 10 tasks
iuioiua opened this issue Mar 26, 2024 · 3 comments
Closed
7 of 10 tasks

todo: remove APIs using DENO_FUTURE=1 #23089

iuioiua opened this issue Mar 26, 2024 · 3 comments
Labels
Milestone

Comments

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 27, 2024

The solution to most of these is to read the DENO_FUTURE environment variable somehow and disable the symbols where they're implemented.

@bartlomieju
Copy link
Member

The solution to most of these is to read the DENO_FUTURE environment variable somehow and disable the symbols where they're implemented.

Which is problematic, because we only have information if the env var is present after the code in relevant extensions has been evaluated. I'll try to come up with a solution.

bartlomieju pushed a commit that referenced this issue Mar 27, 2024
@bartlomieju bartlomieju added this to the 2.0 milestone Apr 3, 2024
iuioiua added a commit that referenced this issue Apr 7, 2024
I'm unsure whether we're planning to make the `Deno.FsFile` constructor
illegal or remove `FsFile` from the `Deno.*` namspace in Deno 2. Either
way, this PR works towards the former. I'll create a superceding PR if
the latter is planned instead.

Towards #23089
iuioiua added a commit that referenced this issue Apr 7, 2024
…Conn).prototype.rid` (#23219)

Towards #23089

---------

Signed-off-by: Asher Gomez <[email protected]>
satyarohith pushed a commit that referenced this issue Apr 11, 2024
I'm unsure whether we're planning to make the `Deno.FsFile` constructor
illegal or remove `FsFile` from the `Deno.*` namspace in Deno 2. Either
way, this PR works towards the former. I'll create a superceding PR if
the latter is planned instead.

Towards #23089
satyarohith pushed a commit that referenced this issue Apr 11, 2024
…Conn).prototype.rid` (#23219)

Towards #23089

---------

Signed-off-by: Asher Gomez <[email protected]>
iuioiua added a commit that referenced this issue Apr 21, 2024
iuioiua added a commit that referenced this issue Apr 21, 2024
@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 22, 2024

Talked with Bartek. This can now be considered completed as flags cannot be easily targeted with DENO_FUTURE=1.

@iuioiua iuioiua closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants