Added `databricks_model_serving` resource #2054

arpitjasa-db · 2023-03-01T20:02:52Z

This PR adds Model Serving Endpoints as a Terraform resource to the Databricks Terraform Provider, addressing #2040.

docs/resources/serving_endpoint.md

common/reflect_resource.go

docs/resources/serving_endpoint.md

serving-endpoints/resource_serving_endpoint.go

docs/resources/serving_endpoint.md

nfx

comments from @alexott

provider/provider.go

serving-endpoints/resource_serving_endpoint.go

serving-endpoints/resource_serving_endpoint_test.go

docs/resources/serving_endpoint.md

vladimirk-db

Can you please provide a PR description? It would make it easier to review for people not familiar with the codebase already.

docs/resources/serving_endpoint.md

serving-endpoints/resource_serving_endpoint.go

common/reflect_resource.go

ankit-db

@arpitjasa-db mind holding merge on this? We have to change the name of the product, and the link to the docs will change. Not sure right now what the link name will be, so give us till the end of the day if that's ok?

arpitjasa-db · 2023-03-03T19:19:37Z

@arpitjasa-db mind holding merge on this? We have to change the name of the product, and the link to the docs will change. Not sure right now what the link name will be, so give us till the end of the day if that's ok?

Yeah no worries, I'll update the PR with the new name once you have it.

arpitjasa-db · 2023-03-03T22:55:29Z

@ankit-db I saw the email from Craig that the name is changing from Serverless Real-time Inference to Model Serving, so I updated the PR accordingly. Please take a look at the PR along with any other ML Inference folks (@sueann or @mehtayogita ) to make sure the rest of the naming and the docs line up with what is expected.

docs/resources/mlflow_model_serving.md

arpitjasa-db · 2023-03-06T06:38:58Z

@nfx @alexott Some of my unit tests seem to be failing with this cryptic error message

testing.go:426: 
        	Error Trace:	/home/runner/work/terraform-provider-databricks/terraform-provider-databricks/qa/testing.go:426
        	            				/opt/hostedtoolcache/go/1.19.6/x64/src/net/http/server.go:2109
        	            				/opt/hostedtoolcache/go/1.19.6/x64/src/net/http/server.go:2947
        	            				/opt/hostedtoolcache/go/1.19.6/x64/src/net/http/server.go:1991
        	            				/opt/hostedtoolcache/go/1.19.6/x64/src/runtime/asm_amd64.s:1594
        	Error:      	Input ('') needs to be valid json.
        	            	JSON parsing error: 'unexpected end of JSON input'
        	Test:       	TestModelServingRead
        	Messages:   	json strings do not match

Do you know what could be causing this? Stepped through the tests in a debugger and it's weird this error seems to show up after the test passes the assertions.

nkvuong · 2023-03-06T14:03:20Z

@arpitjasa-db basically the json parsing error comes from https://github.com/databricks/terraform-provider-databricks/blob/master/qa/testing.go#L426, where ExpectedRequest is an invalid json string.

I then notice this definition in the sdk -
https://github.com/databricks/databricks-sdk-go/blob/main/service/endpoints/model.go#L166

Name string `json:"-" url:"-"`

This might be causing the problem with json marshal

docs/resources/model_serving.md

internal/acceptance/model_serving_test.go

serving/resource_model_serving.go

nfx

lgtm, pending the successful acceptance test results

nfx · 2023-03-08T13:05:28Z

internal/acceptance/model_serving_test.go

+				client.create_model_version(name="%[1]s-model", source=source, run_id=run1_id)
+				while client.get_model_version(name="%[1]s-model", version="1").getStatus() != ModelRegistry.ModelVersionStatus.READY:
+					time.sleep(10)
+				while client.get_model_version(name="%[1]s-model", version="2").getStatus() != ModelRegistry.ModelVersionStatus.READY:


i wonder how can be encode this in our Python SDK :)

arpitjasa-db · 2023-03-08T17:49:44Z

Integration/Acceptance test passes with new version of Go SDK!

ankit-db

LGTM with nit

docs/resources/mlflow_model.md

Co-authored-by: Ankit Mathur <[email protected]>

nkvuong

Some suggested changes in docs

docs/resources/model_serving.md

Co-authored-by: vuong-nguyen <[email protected]>

* Added databricks_model_serving resource (#2054). * Added Unity Catalog on GCP support (#2000). * Deprecate schedule block in databricks_sql_query resource (#2078). * Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067). * Added more testing for databricks_tables data source (#2075). * Added more testing for databricks_schemas data source (#2074). * Migrate databricks_node_type data source to Go SDK (#2070). * Migrate databricks_schemas data to Go SDK (#2065). * Migrate databricks_tables data source to SDK (#2068). * Migrate databricks_views data source to Go SDK (#2073). * Migrated databricks_git_credential to Go SDK (#2069). * Migrated databricks_shares data source to Go SDK (#2072). Updated dependency versions: * Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086). * Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).

arpitjasa-db requested review from nfx and vladimirk-db March 1, 2023 20:02

arpitjasa-db commented Mar 1, 2023

View reviewed changes

docs/resources/serving_endpoint.md Outdated Show resolved Hide resolved

arpitjasa-db force-pushed the endpoints branch 3 times, most recently from 20412f7 to f592dcb Compare March 1, 2023 22:08

alexott reviewed Mar 2, 2023

View reviewed changes

nfx requested changes Mar 2, 2023

View reviewed changes

arpitjasa-db requested review from sueann, mehtayogita and ankit-db March 3, 2023 08:23

vladimirk-db reviewed Mar 3, 2023

View reviewed changes

docs/resources/serving_endpoint.md Outdated Show resolved Hide resolved

docs/resources/serving_endpoint.md Outdated Show resolved Hide resolved

serving-endpoints/resource_serving_endpoint.go Outdated Show resolved Hide resolved

common/reflect_resource.go Outdated Show resolved Hide resolved

arpitjasa-db commented Mar 3, 2023

View reviewed changes

common/reflect_resource.go Outdated Show resolved Hide resolved

ankit-db suggested changes Mar 3, 2023

View reviewed changes

arpitjasa-db requested review from nfx and alexott March 3, 2023 20:13

arpitjasa-db requested review from ankit-db and vladimirk-db March 3, 2023 22:55

sueann reviewed Mar 3, 2023

View reviewed changes

docs/resources/mlflow_model_serving.md Outdated Show resolved Hide resolved

sueann reviewed Mar 3, 2023

View reviewed changes

docs/resources/mlflow_model_serving.md Outdated Show resolved Hide resolved

mehtayogita reviewed Mar 5, 2023

View reviewed changes

docs/resources/mlflow_model_serving.md Outdated Show resolved Hide resolved

docs/resources/mlflow_model_serving.md Outdated Show resolved Hide resolved

arpitjasa-db force-pushed the endpoints branch from 36df16c to 1d3e63b Compare March 6, 2023 06:23

arpitjasa-db force-pushed the endpoints branch from 1a51aad to 3cfbb74 Compare March 6, 2023 18:30

vladimirk-db reviewed Mar 6, 2023

View reviewed changes

docs/resources/model_serving.md Outdated Show resolved Hide resolved

vladimirk-db reviewed Mar 6, 2023

View reviewed changes

internal/acceptance/model_serving_test.go Outdated Show resolved Hide resolved

vladimirk-db reviewed Mar 6, 2023

View reviewed changes

serving/resource_model_serving.go Show resolved Hide resolved

nfx approved these changes Mar 8, 2023

View reviewed changes

nfx linked an issue Mar 8, 2023 that may be closed by this pull request

[FEATURE] Add resource for Serverless Real-Time Inference endpoints #2040

Closed

arpitjasa-db and others added 14 commits March 8, 2023 09:24

Added corner case testing to maximize coverage

8dd7bfd

Added documentation

b6f1427

Address comments

e335683

Fix docs

12df805

Added forcenew to name

ae91472

Updated name to model serving

da1e0fa

Updated additional naming

922a20e

Last name update hopefully

28b00b2

Updated naming to serving

8d2db7e

Update docs

d377bdb

Apply suggestions from code review

c8af1b1

Applied comments

bbf0211

Fixed doc

b8dcb54

Rebased with master

4543dd6

arpitjasa-db force-pushed the endpoints branch from 909468d to 4543dd6 Compare March 8, 2023 17:49

ankit-db approved these changes Mar 8, 2023

View reviewed changes

docs/resources/mlflow_model.md Outdated Show resolved Hide resolved

Update docs/resources/mlflow_model.md

095aa05

Co-authored-by: Ankit Mathur <[email protected]>

nkvuong approved these changes Mar 8, 2023

View reviewed changes

docs/resources/model_serving.md Outdated Show resolved Hide resolved

docs/resources/model_serving.md Outdated Show resolved Hide resolved

docs/resources/model_serving.md Outdated Show resolved Hide resolved

nfx and others added 3 commits March 8, 2023 19:27

Update docs/resources/model_serving.md

475d7c7

Co-authored-by: vuong-nguyen <[email protected]>

Update docs/resources/model_serving.md

15999b1

Co-authored-by: vuong-nguyen <[email protected]>

Update docs/resources/model_serving.md

6d557e6

Co-authored-by: vuong-nguyen <[email protected]>

nfx merged commit c23c570 into databricks:master Mar 8, 2023

arpitjasa-db deleted the endpoints branch March 8, 2023 18:29

nfx mentioned this pull request Mar 9, 2023

Release v1.12.0 #2094

Merged

nkvuong mentioned this pull request Mar 27, 2023

[FEATURE] Create way to enable/disable model serving via Terraform #1224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `databricks_model_serving` resource #2054

Added `databricks_model_serving` resource #2054

arpitjasa-db commented Mar 1, 2023 •

edited

Loading

nfx left a comment

vladimirk-db left a comment

ankit-db left a comment

arpitjasa-db commented Mar 3, 2023

arpitjasa-db commented Mar 3, 2023

arpitjasa-db commented Mar 6, 2023

nkvuong commented Mar 6, 2023

nfx left a comment

nfx Mar 8, 2023

arpitjasa-db commented Mar 8, 2023

ankit-db left a comment

nkvuong left a comment

Added databricks_model_serving resource #2054

Added databricks_model_serving resource #2054

Conversation

arpitjasa-db commented Mar 1, 2023 • edited Loading

nfx left a comment

Choose a reason for hiding this comment

vladimirk-db left a comment

Choose a reason for hiding this comment

ankit-db left a comment

Choose a reason for hiding this comment

arpitjasa-db commented Mar 3, 2023

arpitjasa-db commented Mar 3, 2023

arpitjasa-db commented Mar 6, 2023

nkvuong commented Mar 6, 2023

nfx left a comment

Choose a reason for hiding this comment

nfx Mar 8, 2023

Choose a reason for hiding this comment

arpitjasa-db commented Mar 8, 2023

ankit-db left a comment

Choose a reason for hiding this comment

nkvuong left a comment

Choose a reason for hiding this comment

Added `databricks_model_serving` resource #2054

Added `databricks_model_serving` resource #2054

arpitjasa-db commented Mar 1, 2023 •

edited

Loading