Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unity Catalog on GCP support #2000

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Add Unity Catalog on GCP support #2000

merged 5 commits into from
Mar 3, 2023

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 14, 2023

  • Add support for databricks_gcp_service_account attribute for databricks_storage_credential and databricks_metastore_data_access resources
  • Update docs for UC resources to highlight GCP-equivalent syntax
  • Adds a user guide for Unity Catalog on GCP

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #2000 (c7f0ace) into master (121fb14) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c7f0ace differs from pull request most recent head 86cbf0e. Consider uploading reports for the commit 86cbf0e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2000   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         136      136           
  Lines       11079    11081    +2     
=======================================
+ Hits         9948     9950    +2     
  Misses        732      732           
  Partials      399      399           
Impacted Files Coverage Δ
catalog/resource_metastore_data_access.go 87.93% <100.00%> (+0.21%) ⬆️
catalog/resource_storage_credential.go 100.00% <100.00%> (ø)

@nkvuong nkvuong force-pushed the doc/uc_gcp_guide branch from 72b4771 to c7f0ace Compare March 3, 2023 16:47
@nkvuong nkvuong marked this pull request as ready for review March 3, 2023 16:47
@nkvuong nkvuong changed the title Add Unity Catalog guides for GCP Add Unity Catalog on GCP support Mar 3, 2023
@nkvuong
Copy link
Contributor Author

nkvuong commented Mar 3, 2023

acceptance tests running

@nkvuong
Copy link
Contributor Author

nkvuong commented Mar 3, 2023

acceptance tests passed

@nfx nfx merged commit ee488e8 into master Mar 3, 2023
@nfx nfx deleted the doc/uc_gcp_guide branch March 3, 2023 18:32
nfx added a commit that referenced this pull request Mar 9, 2023
* Added databricks_model_serving resource (#2054).
* Added Unity Catalog on GCP support (#2000).
* Deprecate schedule block in databricks_sql_query resource (#2078).
* Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067).
* Added more testing for databricks_tables data source (#2075).
* Added more testing for databricks_schemas data source (#2074).
* Migrate databricks_node_type data source to Go SDK (#2070).
* Migrate databricks_schemas data to Go SDK (#2065).
* Migrate databricks_tables data source to SDK (#2068).
* Migrate databricks_views data source to Go SDK (#2073).
* Migrated databricks_git_credential to Go SDK (#2069).
* Migrated databricks_shares data source to Go SDK (#2072).

Updated dependency versions:

* Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086).
* Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
@nfx nfx mentioned this pull request Mar 9, 2023
nfx added a commit that referenced this pull request Mar 9, 2023
* Added databricks_model_serving resource (#2054).
* Added Unity Catalog on GCP support (#2000).
* Deprecate schedule block in databricks_sql_query resource (#2078).
* Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067).
* Added more testing for databricks_tables data source (#2075).
* Added more testing for databricks_schemas data source (#2074).
* Migrate databricks_node_type data source to Go SDK (#2070).
* Migrate databricks_schemas data to Go SDK (#2065).
* Migrate databricks_tables data source to SDK (#2068).
* Migrate databricks_views data source to Go SDK (#2073).
* Migrated databricks_git_credential to Go SDK (#2069).
* Migrated databricks_shares data source to Go SDK (#2072).

Updated dependency versions:

* Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086).
* Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants