-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new RPCs getrawislock and getrawbestchainlock #6455
base: develop
Are you sure you want to change the base?
Conversation
Guix Automation has began to build this PR tagged as v22.1.0-devpr6455.a4256c92. A new comment will be made when the image is pushed. |
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6455.a4256c92. The image should be on dockerhub soon. |
for (const auto idx : irange::range(txids.size())) { | ||
const uint256 txid(ParseHashV(txids[idx], "txid")); | ||
|
||
LLMQContext& llmq_ctx = EnsureLLMQContext(node); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider defining llmq_ctx
outside the loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will wait feedback from pshenmic first
const uint256 txid(ParseHashV(txids[idx], "txid")); | ||
|
||
LLMQContext& llmq_ctx = EnsureLLMQContext(node); | ||
llmq::CInstantSendLockPtr islock = llmq_ctx.isman->GetInstantSendLockByTxid(txid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider
if (auto islock = CHECK_NONFATAL(llmq_ctx.isman)->GetInstantSendLockByTxid(txid); islock != nullptr) {
CDataStream ssTx(SER_NETWORK, PROTOCOL_VERSION);
ssTx << *islock;
result_arr.push_back(HexStr(ssTx));
} else {
result_arr.push_back("None");
}
it's a draft because I need a confirmation from pshenmic that it works as he expects.
Issue being fixed or feature implemented
#6391
What was done?
Implemented 2 new RPC
getrawislock
andgetrawbestchainlock
which output is similar to ZMQ output.How Has This Been Tested?
See new asserts in functional test interface_zmq_dash.py
Breaking Changes
N/A
Checklist: