Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add InstantLock and ChainLock data buffers in Core RPC #6391

Open
pshenmic opened this issue Nov 12, 2024 · 2 comments
Open

feature: add InstantLock and ChainLock data buffers in Core RPC #6391

pshenmic opened this issue Nov 12, 2024 · 2 comments
Assignees
Milestone

Comments

@pshenmic
Copy link

Is your feature request related to a problem? Please describe.

To register an identity in the DashPlatform network, there is a required field of InstantLock or ChainLock buffer in IdentityCreateTransition. You first create and broadcast Core transaction, then wait for InstantLock or ChainLock, and then create and broadcast transaction in the Platform chain with that data.

The problem is in obtaining these lock signatures, because it is only available in the ZMQ, but its not so easy to use on the client, as it is requires a TCP connection and adds a lot of complexity in the client code, making it almost impossible in the web without self-written WebSocket gateways.

Core RPC also misses such information right now, however query methods like verifychainlock and verifyislock are presented (that accepts the same buffer). GetTransaction and GetBlock Core RPC queries already has a boolean field, it would be nice to see an actual buffer there too.

Describe the solution you'd like

It would be really great to see instantlock and chainlock buffers in the gettransaction and getblock RPC responses, but separate query would work as well

Additional context

pshenmic/platform-cli#13 (comment)

@riongull
Copy link

Proposals related to and motivated by this issue:

https://www.dashcentral.org/p/DCD_RPC-Web-Proxy-Explorer_2024-Q4-fixed

https://www.dashcentral.org/p/Dev_Web_SDK-Platform_Id_with_Explorer

https://www.dashcentral.org/p/Dev_P2P_and_ZMQ_Explorers

Having IS/CL data in the Core RPC would likely improve certain use cases, but being able to work around this with separate services is a reasonable trade off until addressed more thoroughly.

@PastaPastaPasta PastaPastaPasta added this to the 22.1 milestone Nov 19, 2024
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Nov 19, 2024

I expect this to be implemented in the next week or two. It'll then be included in latest nightlies, and released in v22.1; thanks for the good request, and clear issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants