-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the installed state in the template for toggling pause/stop #795
Conversation
Simply handling a new initial state that we have: installed. Here's the manual tests performed. A installed, but never run, workflow: A stopped workflow: A running workflow: A paused workflow (reloaded browser to confirm it's not only a local state): A running (restart?) workflow: Stopped again workflow: |
We should really get rid of the installed state before release, putting up some PRs to address this... |
(Presumably #805 makes this redundant?) |
Sorry @kinow it looks like this one won't be needed now - OK? |
Yup! Not a problem, important thing is it was fixed :) closing now, thanks! |
Oops, hang on, sorry! #748 is about greying out the play icons, not just the about-to-be-removed "installed" state. So maybe this PR could be adapted once installed is removed? |
Luckily branch deletion is reversible 😁 |
Branch restored! 😌 |
Damn it, premature branch restoration! I just ran the #805 branches and it looks like the icons are correctly greyed there for not-yet-run workflows. |
I think #805 has now superseded this the lazy way (by deleting the extra state!). |
OK you can delete your branch again @kinow 😁 |
These changes close #748
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.