Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task matching bug #4881

Merged
merged 3 commits into from
May 20, 2022
Merged

Fix task matching bug #4881

merged 3 commits into from
May 20, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented May 18, 2022

Can manually test by following steps to reproduce in the issue above

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit).
  • Appropriate change log entry included.
  • No documentation update required.

@MetRonnie MetRonnie added the bug Something is wrong :( label May 18, 2022
@MetRonnie MetRonnie added this to the cylc-8.0rc4 milestone May 18, 2022
@MetRonnie MetRonnie self-assigned this May 18, 2022
@MetRonnie MetRonnie requested review from oliver-sanders and wxtim May 19, 2022 12:16
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

[#4738](https://github.com/cylc/cylc-flow/pull/4738) and
[#4739](https://github.com/cylc/cylc-flow/pull/4739) - Implement `cylc trigger
[--flow=] [--wait]` for manual triggering with respect to active flows (the
default), specific flows, new flows, or one-off task runs.
default), specific flows, new flows, or one-off task runs. This replaces
the `--reflow` option from earlier pre-release versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wxtim wxtim merged commit 2233270 into cylc:master May 20, 2022
@MetRonnie MetRonnie deleted the task-matching branch May 20, 2022 08:37
wxtim added a commit to wxtim/cylc that referenced this pull request May 27, 2022
* 'master' of https://github.com/cylc/cylc: (47 commits)
  Global platform default directives (cylc#4896)
  Raise an error if the user tries to set owner. (cylc#4860)
  Raise error if there is a relative path in `global.cylc[install]source dirs` (cylc#4887)
  Added a noqa tag to a new flake8-simplify case. (cylc#4895)
  Update change log.
  Don't prompt to clean no workflows.
  Bump to next dev version
  Fix task matching bug (cylc#4881)
  Expand comma separated platform names correctly (cylc#4880)
  resolvers: add a couple of comments
  Prepare release 8.0rc3
  Fix change log.
  Add & amalgamate jinja2 error tests
  shellcheck fix
  Tweak show help text.
  Fix wrong context lines for jinja2 error
  Fix missing context lines for jinja2 error
  Improve new func. test.
  Syntax highlighting: don't symlink files now they are extracted using cylc get-resources
  Emacs syntax highlighting: fix filename pattern matching
  ...
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task matching fails silently when the cycle point does not exactly follow [scheduler]cycle point format
4 participants