Expand comma separated platform names correctly #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamel
reviewed
May 18, 2022
Co-authored-by: Melanie Hall <[email protected]>
Wrong PR? And isn't the problem that it didn't expand in the sparse config? |
Yes #4854
The problem is that it expands the sparse config after creating the dense config, and therefore doesn't include that expansion in the dense config. |
MetRonnie
approved these changes
May 19, 2022
| @@ -1493,9 +1493,11 @@ def load(self): | |||
| LOG.error(f'bad {conf_type} {fname}') | |||
| raise | |||
|
|
|||
| # Expand platforms needs to be performed first because it | |||
| # manipulates the sparse config. | |||
| self._expand_platforms() | |||
| self._set_default_editors() | |||
There was a problem hiding this comment.
(I think the fact that the dense config is expanded in a method called _set_default_editors() is a bit troublesome. I am addressing this as part of #4815)
|
May want to add a changelog entry for this as it didn't make it into the same release as #4854 |
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
May 27, 2022
* 'master' of https://github.com/cylc/cylc: (47 commits) Global platform default directives (cylc#4896) Raise an error if the user tries to set owner. (cylc#4860) Raise error if there is a relative path in `global.cylc[install]source dirs` (cylc#4887) Added a noqa tag to a new flake8-simplify case. (cylc#4895) Update change log. Don't prompt to clean no workflows. Bump to next dev version Fix task matching bug (cylc#4881) Expand comma separated platform names correctly (cylc#4880) resolvers: add a couple of comments Prepare release 8.0rc3 Fix change log. Add & amalgamate jinja2 error tests shellcheck fix Tweak show help text. Fix wrong context lines for jinja2 error Fix missing context lines for jinja2 error Improve new func. test. Syntax highlighting: don't symlink files now they are extracted using cylc get-resources Emacs syntax highlighting: fix filename pattern matching ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
Issue summary:
#4854 did not expand comma separated platform config items in the dense config.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.[platforms]section; Add warning if a platform name regex matches localhost #4854).