Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: init/validate-genesis cmd include gravity module by default #639

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Problem: init/validate-genesis cmd include gravity module by default #639

merged 4 commits into from
Aug 17, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 12, 2022 •
edited
Loading

Solution:

  • Use different module managers according to --unsafe-experimental flag

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner August 12, 2022 10:29
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team August 12, 2022 10:29
@yihuang yihuang changed the title Problem: inconsistent logic regarding experimental modules in genesis… Problem: inconsistent logic regarding experimental modules in genesis export/validate Aug 12, 2022
yihuang
yihuang commented Aug 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang changed the title Problem: inconsistent logic regarding experimental modules in genesis export/validate Problem: init/validate-genesis include gravity module by default Aug 12, 2022
@yihuang yihuang changed the title Problem: init/validate-genesis include gravity module by default Problem: init/validate-genesis cmd include gravity module by default Aug 12, 2022
JayT106
JayT106 reviewed Aug 12, 2022
View reviewed changes
app/app.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #639 (24bc6f7) into main (4be9702) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   32.93%   32.91%   -0.03%     
==========================================
  Files          34       34              
  Lines        1603     1604       +1     
==========================================
  Hits          528      528              
- Misses       1022     1023       +1     
  Partials       53       53
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
app/state.go 0.00% <0.00%> (ø)

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 12, 2022

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Can check further progress here

@yihuang yihuang requested a review from JayT106 August 15, 2022 09:24
@JayT106
Copy link
Collaborator

JayT106 commented Aug 15, 2022

lgtm, once the integration tests got fixed and the pystarport update to the crypto.com repo

@yihuang
Problem: inconsistent logic regarding experimental modules in genesis…
9c2afa7 
… export/validate

Solution:
- Use different module managers according to --unsafe-experimental flag

fix experimental flag in unit tests

Update CHANGELOG.md

use cmd-flags to fix integration tests

pystarport merged to main
@yihuang yihuang force-pushed the refactor-sim-test branch from 4d13976 to 9c2afa7 Compare August 15, 2022 15:20
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 15, 2022

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Can check further progress here

@yihuang yihuang enabled auto-merge (squash) August 17, 2022 03:43
@mmsqe mmsqe mentioned this pull request Aug 17, 2022
Merged
13 tasks
@yihuang yihuang merged commit fb80ae1 into crypto-org-chain:main Aug 17, 2022
@yihuang yihuang mentioned this pull request Aug 18, 2022
Closed
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
This was referenced Apr 29, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy thomas-nguy is a code owner automatically assigned from crypto-org-chain/cronos-dev

@JayT106 JayT106 Awaiting requested review from JayT106

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @JayT106 @mmsqe