Problem: no efficient batch query for encryption keys #1415
Conversation
yihuang
requested review from
mmsqe and
leejw51crypto
and removed request for
a team
WalkthroughThe update enhances the e2ee module in the crypto-org-chain/cronos project by introducing a custom keyring implementation and batch keys query functionality. These changes aim to improve efficiency and scalability across various components like CLI tools, integration tests, and protocol buffers. Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (2)
Files selected for processing (8)
Files not reviewed due to errors (1)
Files skipped from review as they are similar to previous changes (6)
Additional Context UsedLanguageTool (769)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 35.80% 35.80% -0.01%
==========================================
Files 136 136
Lines 9864 9879 +15
==========================================
+ Hits 3532 3537 +5
- Misses 5935 5945 +10
Partials 397 397
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
CHANGELOG.md (2)
Line range hint
43-43: Correct the unordered list marker for consistency.- - [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API. + * [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API.
Line range hint
158-158: Correct the unordered list marker for consistency.- - [cronos#695](https://github.com/crypto-org-chain/cronos/pull/695) Implement ADR-007, generic events format with indexed params. + * [cronos#695](https://github.com/crypto-org-chain/cronos/pull/695) Implement ADR-007, generic events format with indexed params.
Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> update swagger typo
yihuang
force-pushed
the
encrypt-to-validator
branch
from
d69613a to
64cd21e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
CHANGELOG.md (2)
Line range hint
43-43: Standardize list marker style to use asterisks (*) instead of dashes (-) for consistency.- - [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API. + * [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API.
Line range hint
55-55: Standardize list marker style to use asterisks (*) instead of dashes (-) for consistency.- - [#1362](https://github.com/crypto-org-chain/cronos/pull/1362) Log blacklist addresses. + * [#1362](https://github.com/crypto-org-chain/cronos/pull/1362) Log blacklist addresses.
662c643
…in#1415) Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> update swagger typo
Problem: no end-to-end encryption module (crypto-org-chain#1407) * Problem: no end-to-end encryption module add keeper add grpc query signer option getter/setter genesis init/export fix lint * fix proto lint * fix test * register codec * changelog * fix build * Update x/e2ee/types/keys.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> * Update x/e2ee/types/codec.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]> Problem: encryption-key cmd is not supported (crypto-org-chain#1409) * Problem: encryption-key cmd is not supported * gen doc * add validate Problem: no keyring interface for e2ee to store arbitrary payload (crypto-org-chain#1413) changelo add age encrypt/decrypt in unit test Update x/e2ee/keyring/keyring.go Signed-off-by: yihuang <[email protected]> fix lint fix build Problem: no encrypt and decrypt cmds for message (crypto-org-chain#1411) * Problem: no encrypt and decrypt cmds for message * fix doc * add gen * test * cleanup * move command to e2ee module move encrypt cmd to e2ee module move decrypt cmd to e2ee update integration test store key as string, to make autocli better fix integration test Update x/e2ee/client/cli/encrypt.go Signed-off-by: yihuang <[email protected]> fix lint --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]> Problem: no efficient batch query for encryption keys (crypto-org-chain#1415) Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> update swagger typo fix build proposal handler update version check exist Problem: proto-gen fails in CI (crypto-org-chain#1392) * Problem: proto-gen fails in CI * Apply suggestions from code review add cronos msg add store-block-list cmd refresh block list add handler update deps add handler lint fix cmd test store list set with ante move to util fix ibc Revert "set with ante" This reverts commit c2700f5. reject on err fix prepare proposal fix proto lint
* Problem: e2ee module is not backported Problem: no end-to-end encryption module (#1407) * Problem: no end-to-end encryption module add keeper add grpc query signer option getter/setter genesis init/export fix lint * fix proto lint * fix test * register codec * changelog * fix build * Update x/e2ee/types/keys.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> * Update x/e2ee/types/codec.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]> Problem: encryption-key cmd is not supported (#1409) * Problem: encryption-key cmd is not supported * gen doc * add validate Problem: no keyring interface for e2ee to store arbitrary payload (#1413) changelo add age encrypt/decrypt in unit test Update x/e2ee/keyring/keyring.go Signed-off-by: yihuang <[email protected]> fix lint fix build Problem: no encrypt and decrypt cmds for message (#1411) * Problem: no encrypt and decrypt cmds for message * fix doc * add gen * test * cleanup * move command to e2ee module move encrypt cmd to e2ee module move decrypt cmd to e2ee update integration test store key as string, to make autocli better fix integration test Update x/e2ee/client/cli/encrypt.go Signed-off-by: yihuang <[email protected]> fix lint --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]> Problem: no efficient batch query for encryption keys (#1415) Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> update swagger typo fix build proposal handler update version check exist Problem: proto-gen fails in CI (#1392) * Problem: proto-gen fails in CI * Apply suggestions from code review add cronos msg add store-block-list cmd refresh block list add handler update deps add handler lint fix cmd test store list set with ante move to util fix ibc Revert "set with ante" This reverts commit c2700f5. reject on err fix prepare proposal fix proto lint * cmd to encrypt to validators * fix test * temp * fix test * improve test * Problem: no validate for malformed e2ee key in register (#1421) * Problem: no validate for malformed e2ee key in register * update doc * Apply suggestions from code review * cleanup --------- Co-authored-by: yihuang <[email protected]> * cleanup test * revert * fix test * fix test * remove mempool blocked-addresses * fix test * fix test * fix test * fix patch * avoid prompt * encrypt clear list * cleanup * add validate * avoid concurrent mutate * Update app/proposal.go Signed-off-by: mmsqe <[email protected]> * cleanup * proto-gen --------- Signed-off-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]> Co-authored-by: mmsqe <[email protected]>
…in#1415) Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> update swagger typo
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
Enhancements
Documentation