Problem: CosmWasm is not enabled on chain-main

[devashishdxt]

Solution: Integrated wasmd in app.go (have used temporary forks for ics29 fee middleware changes)

[codecov]

Codecov Report

Merging #780 (f109494) into master (a7ac0c3) will increase coverage by 0.95%.
The diff coverage is 37.83%.

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   20.17%   21.13%   +0.95%     
==========================================
  Files          99       98       -1     
  Lines       11325    10813     -512     
==========================================
  Hits         2285     2285              
+ Misses       8553     8038     -515     
- Partials      487      490       +3     

Flag	Coverage Δ
integration_tests	18.57% <48.27%> (+0.20%)	⬆️
unit_tests	7.22% <0.00%> (+0.35%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/test_helpers.go	0.00% <ø> (ø)
app/app.go	45.22% <36.84%> (+22.97%)	⬆️
cmd/chain-maind/app/app.go	53.84% <37.50%> (-0.11%)	⬇️
app/ante.go	61.29% <40.00%> (+16.55%)	⬆️
x/supply/keeper/genesis.go	6.02% <0.00%> (-1.82%)	⬇️
x/icaauth/types/params.pb.go	0.00% <0.00%> (-1.21%)	⬇️
app/encoding.go	100.00% <0.00%> (ø)
x/nft/simulation/operations.go	0.00% <0.00%> (ø)
app/genesis.go
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ac0c3...f109494. Read the comment docs.

[yihuang]

The windows build doesn't work because no prebuilt libwasmvm.dll in wasmvm repo.

[yihuang]

The nix building works now, can you add some basic integration test to show it works?

[devashishdxt]

/runsim

[github-actions]

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

[tomtau]

Would it be possible to fix the Windows build? I think one can just add a cargo build step to this batch file: https://github.com/crypto-org-chain/chain-main/blob/master/makewin.bat to build wasmvm and have it on the path?

[github-actions]

❌ /runsim simulation test has failed 😅
Can further check here

[devashishdxt]

/runsim

[github-actions]

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

[devashishdxt]

• ICA https://github.com/CosmWasm/wasmd/blob/v0.27.0/app/app.go#L485-L492 -- it mentions it's experimental, so perhaps better to omit?

This is their sample icaauth module. We already have wiring for that in app.go.

[github-actions]

❌ /runsim simulation test has failed 😅
Can further check here

[devashishdxt]

• https://github.com/CosmWasm/wasmd/blob/v0.27.0/app/app.go#L765-L768 -- InitializePinnedCodes -- not sure if needed?

Added

[devashishdxt]

Also, I guess the binary release via GoReleaser may not work any more? (at least, I assume it won't bundle the wasmvm dynamic library built by Rust by default)

As far as I understand this, pre-built dynamic libraries for linux and mac are linked by wasmvm. For windows, we may have to include .dll until CosmWasm/wasmvm#288 is merged and released. I've asked a question on discord for more details on this.

[github-actions]

❌ /runsim simulation test has failed 😅
Can further check here

[yihuang]

Also, I guess the binary release via GoReleaser may not work any more? (at least, I assume it won't bundle the wasmvm dynamic library built by Rust by default)

As far as I understand this, pre-built dynamic libraries for linux and mac are linked by wasmvm. For windows, we may have to include .dll until CosmWasm/wasmvm#288 is merged and released. I've asked a question on discord for more details on this.

I guess it won't be packaged by goreleaser, and I've opened an issue that we might adopt the nix solution used in cronos: #781

[devashishdxt]

Would it be possible to fix the Windows build? I think one can just add a cargo build step to this batch file: https://github.com/crypto-org-chain/chain-main/blob/master/makewin.bat to build wasmvm and have it on the path?

I'll do this in next PR.

[tomtau]

updating the fork -- the windows build is currently marked as "Required" workflow to pass, so not sure if this can be merged without it being fixed

[yihuang]

❌ /runsim simulation test has failed 😅 Can further check here

it failed, should we run again?

[devashishdxt]

❌ /runsim simulation test has failed 😅 Can further check here

it failed, should we run again?

Yes. We can run again. It failed because it didn't find runsim binary.

[devashishdxt]

/runsim

[github-actions]

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

[github-actions]

✅ /runsim simulation test has succeeded 🎉
Can further check here

[yihuang]

LGTM