Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support to cross builder #288

Closed
wants to merge 8 commits into from

Conversation

webmaster128
Copy link
Member

This largely builds on #117 which can now be used with Wasmer 2.1.
With this we can build an api/wasmvm.dll.

Closes #117
Closes #28

@webmaster128 webmaster128 mentioned this pull request Jan 1, 2022
@webmaster128 webmaster128 force-pushed the windows-support-2022-edition branch from f01f5c5 to 8e6edd4 Compare January 2, 2022 10:26
@webmaster128 webmaster128 force-pushed the windows-support-2022-edition branch 2 times, most recently from c30d0c4 to 0143b2e Compare January 2, 2022 10:47
@webmaster128 webmaster128 force-pushed the windows-support-2022-edition branch from 0143b2e to 3896cf5 Compare January 2, 2022 10:51
@leejw51crypto
Copy link

leejw51crypto commented Jun 15, 2022

unit test fails here by this reason
create_dir_all(path).map_err(|e| {
VmError::cache_err(format!(
"Error creating directory {}: {}",
path.display(),
e
))
})?;

  1. path separator \\ -> / , like normalize_path(path.display())
  2. probably ignore second {} or "Error creating directory {}"

@devashishdxt
Copy link

One issue I found is that loupe reports different module size on Windows and other OSes (here).

@webmaster128
Copy link
Member Author

This work has been integrated in the meantime. See #389 for an overview of the state of Windows support.

@webmaster128 webmaster128 deleted the windows-support-2022-edition branch January 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows support
3 participants