Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: change ack processing in provider middleware #1858

Closed
wants to merge 1 commit into from
Closed

fix!: change ack processing in provider middleware #1858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/ccv/provider/ibc_middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (im IBCMiddleware) OnRecvPacket(
// we know that the IBC transfer succeeded. That entails
// that the packet data is valid and can be safely
// deserialized without checking errors.
if ack.Success() {
if ack == nil {
// execute the middleware logic only if the sender is a consumer chain
consumerID, err := im.keeper.IdentifyConsumerChainIDFromIBCPacket(ctx, packet)
if err != nil {
Expand Down
Loading